From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50421D6261A for ; Fri, 23 Jan 2026 07:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ci5XpdL6Ckv6/xMJXvvA3jMGPk+1HVwQB1U9V/A6t2Q=; b=JSWY/j2xhOazym aLDyL5ufycxHZbTevQgRDzLqIoaS9t6jSqk+rHm4xS/A3gA73zrqTTa4Vn/asuFuCCwtxX0u86aTJ ul3dE/9O0DOMK3MqBNgZaEeEk1e+MXgWkRus2y+fzy/Y/bRtsWgkQp4TQyjMXLzCuAkFAqpO2A3iW 9fZ5i7qFLU5HvMs9uKaTYjdS+V8FS6BXjTs+pHuIb4gflqW/sEOSNSrWEi0kOQm3Hgj0Z7G6OF1ly PVpCbZbVy2gzTs92gEM3LAKESzWt8tHzGxeOg/Vpw3g5CJKn1LcTrUur4i90UGdr3oOeQva9C8F9P 63JBomeAPXKNyGBqei2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vjBJN-00000008La6-3Rqy; Fri, 23 Jan 2026 07:10:29 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vjBJM-00000008LZq-0qyl for linux-riscv@lists.infradead.org; Fri, 23 Jan 2026 07:10:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4E71560054; Fri, 23 Jan 2026 07:10:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6E1CC4CEF1; Fri, 23 Jan 2026 07:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769152227; bh=wbGh1ZtM/36iU9DgLPApFyYNdsO0J799XixK0BLHoIM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TwhJImvmQURHTZKr0XxX4H/xYDIWbWQNxgea7t0fZs6g7Ti7Q1kiu8cPA1Zj8QlC+ bx1167gtSXyXBgpR9csWc0+dqkIDMmpszTBm7GbN7sqJVp12fqlj0a3tIIMaP6dN+N pu7zoY9G6R/SGdMMbGfqUbLez7p//t8K5lQwccIdht4unobyU1kmsX6LddQoC1eyc6 nxn2edAK1etPkspiDMCAZXYNUv2A0IL5vZoe/wb25lvtnxX1nJ3XiFGiLcSCaMvCpY 2Gtl/HQ/boyzmqL5PUgfkhBMpXfb3OEoImA3mbqIi39kWPe3pYyd4w0bXQq0mh2Y55 GCsOmXqQRnpKA== Message-ID: <1bde71b1-1a7f-42d2-afce-c206269dee6f@kernel.org> Date: Fri, 23 Jan 2026 08:10:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: soc: tenstorrent: Add tenstorrent,atlantis-syscon To: Anirudh Srinivasan , Drew Fustini , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, joel@jms.id.au, fustini@kernel.org, mpe@kernel.org, mpe@oss.tenstorrent.com, npiggin@oss.tenstorrent.com, agross@kernel.org, agross@oss.tenstorrent.com, bmasney@redhat.com References: <20260122-atlantis-clocks-v2-0-c66371639e66@oss.tenstorrent.com> <20260122-atlantis-clocks-v2-1-c66371639e66@oss.tenstorrent.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260122-atlantis-clocks-v2-1-c66371639e66@oss.tenstorrent.com> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 22/01/2026 23:36, Anirudh Srinivasan wrote: > Document bindings for Tenstorrent Atlantis syscon that manages clocks > and resets. This syscon block is instantiated 4 times in the SoC. > This commit documents the clocks from the RCPU syscon block. > > Signed-off-by: Anirudh Srinivasan > --- > .../tenstorrent/tenstorrent,atlantis-syscon.yaml | 90 ++++++++++++++++++ > MAINTAINERS | 2 + > .../clock/tenstorrent,atlantis-syscon.h | 101 +++++++++++++++++++++ > 3 files changed, 193 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml > new file mode 100644 > index 000000000000..49fbe2423be0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tenstorrent Atlantis SoC Syscon > + > +maintainers: > + - Anirudh Srinivasan > + > +description: > + Multifunctional register block found in Tenstorrent Atlantis SoC whose main function > + is to control clocks and resets. This Block is instantiated multiple times in the SoC, Please wrap code according to the preferred limit expressed in Kernel coding style (checkpatch is not a coding style description, but only a tool). However don't wrap blindly (see Kernel coding style). > + each block controls clock and resets for a different subsystem. > + > + RCPU syscon serves low speed IO interfaces on chip > + PCIe syscon serves all PCIe related functions > + HSIO syscon serves high speed IO interfaces (Ethernet, USB) > + MM syscon serves GPU, display and video processing functions Same feedback - clock controllers go to clock, not soc. > + > +properties: > + compatible: > + enum: > + - tenstorrent,atlantis-syscon-rcpu > + - tenstorrent,atlantis-syscon-pcie > + - tenstorrent,atlantis-syscon-mm > + - tenstorrent,atlantis-syscon-hsio Why do you call everything syscon? syscon is not a hardware name. How is this exactly called in your datasheet? > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + description: > + See for valid indices. > + > + "#reset-cells": > + const: 1 > + > + tenstorrent,syscon-rcpu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle reference to RCPU syscon, needed by other 3 syscons (PCIe, MM, HSIO) > + as the control registers for the PLLs that drive these subsystems are in RCPU > + syscon's range > + > +required: > + - compatible > + - reg > + - clocks > + - "#clock-cells" > + - "#reset-cells" > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - tenstorrent,atlantis-syscon-pcie > + - tenstorrent,atlantis-syscon-mm > + - tenstorrent,atlantis-syscon-hsio > + then: > + required: > + - tenstorrent,syscon-rcpu else - properties false, see other examples how to do it. > + > +additionalProperties: false > + > +examples: > + - | > + syscon_rcpu: system-controller@a8000000 { Drop entire example, one is enough. > + compatible = "tenstorrent,atlantis-syscon-rcpu"; > + reg = <0xa8000000 0x10000>; > + clocks = <&osc_24m>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + - | > + syscon_hsio: system-controller@e00c0000 { Drop unused label. > + compatible = "tenstorrent,atlantis-syscon-hsio"; > + reg = <0xe00c0000 0x500>; > + clocks = <&osc_24m>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + tenstorrent,syscon-rcpu = <&syscon_rcpu>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index dc731d37c8fe..19a98b1fa456 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22535,7 +22535,9 @@ L: linux-riscv@lists.infradead.org > S: Maintained > T: git https://github.com/tenstorrent/linux.git > F: Documentation/devicetree/bindings/riscv/tenstorrent.yaml > +F: Documentation/devicetree/bindings/soc/tenstorrent/tenstorrent,atlantis-syscon.yaml > F: arch/riscv/boot/dts/tenstorrent/ > +F: include/dt-bindings/clock/tenstorrent,atlantis-syscon.h > > RISC-V THEAD SoC SUPPORT > M: Drew Fustini > diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h b/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h > new file mode 100644 > index 000000000000..053cef2b43c8 > --- /dev/null > +++ b/include/dt-bindings/clock/tenstorrent,atlantis-syscon.h Name will follow bindings. > Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv