From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0512EB64D9 for ; Wed, 5 Jul 2023 03:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/wODjrD7MFBTrvvssL59dgZ4KY2sy+AsY4bSfJGW7VY=; b=xIrK1tpDeJpnc7 dlgBKlP6xSqlgzmkKR+H//oi5nWogSYpA/GBq7FzU5VfcvuubgBzbcNjSKYTp5w+lnPSOwFGbf/5h IX/PY5e3YyYj+owoc9TCTenEj3rtrpoJVz/DJ8Y/IpsrZfhxMOM+nkD1pEAmyhOtDyciujNnKKoAC 5cr8ycwCJs9ocH/9gzwtvm4PiDXgvOEEKz4mcZzrOwoW9YB5Qg7pilX+6SXRkSWD8j4V/Gmr6E0vI XvFZjWUBacDPqYQizwgyO1fnu7BdnU73sIaIHCx/Qy+yiKJAxLiHdli/XcWNPm8AkLjI3NckNeKsF 5qVE2zMIiR4Q+e1V5eng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGtO5-00EhhZ-01; Wed, 05 Jul 2023 03:41:05 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGtO2-00Ehh4-3A for linux-riscv@lists.infradead.org; Wed, 05 Jul 2023 03:41:04 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 080E824E01A; Wed, 5 Jul 2023 11:40:45 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 11:40:45 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 11:40:44 +0800 Message-ID: <1e9dedc6-dee3-b65d-2823-0468fcb13193@starfivetech.com> Date: Wed, 5 Jul 2023 11:40:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RESEND v1 2/2] riscv: dts: starfive: Add spi node for JH7110 SoC Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Linus Walleij References: <20230704092200.85401-1-william.qiu@starfivetech.com> <20230704092200.85401-3-william.qiu@starfivetech.com> <7f3b600d-d315-22d6-b987-eabfe1b04fdf@linaro.org> From: William Qiu In-Reply-To: <7f3b600d-d315-22d6-b987-eabfe1b04fdf@linaro.org> X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_204103_155656_5BCD69B2 X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/7/4 17:39, Krzysztof Kozlowski wrote: > On 04/07/2023 11:22, William Qiu wrote: >> Add spi node for JH7110 SoC. >> >> Co-developed-by: Xingyu Wu > > Missing SoB. > It looks like that drop it is the best solution. >> Signed-off-by: William Qiu >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 52 ++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 98 +++++++++++++++++++ >> 2 files changed, 150 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 2a6d81609284..a066d2e399c4 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -126,6 +126,20 @@ &i2c6 { >> status = "okay"; >> }; >> >> +&spi0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&spi0_pins>; >> + status = "okay"; >> + >> + spi_dev0: spi@0 { >> + compatible = "st,m25p80"; >> + pl022,com-mode = <1>; >> + spi-max-frequency = <10000000>; >> + reg = <0>; > > reg is always following compatible, not somewhere deep in properties. > Will update. >> + status = "okay"; > > okay is by default > Will drop. >> + }; >> +}; > > > Best regards, > Krzysztof > Thanks for taking time to review this patch series. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv