linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: richard.weiyang@gmail.com (Wei Yang)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] Extract initrd free logic from arch-specific code.
Date: Thu, 29 Mar 2018 09:12:10 +0800	[thread overview]
Message-ID: <20180329011210.GA4275@WeideMacBook-Pro.local> (raw)
In-Reply-To: <CAGXu5jLioqnOQniXuuNS=PjeAgJr1=BL78Cqu0cwu_Y5e-NDZA@mail.gmail.com>

On Wed, Mar 28, 2018 at 09:55:07AM -0700, Kees Cook wrote:
>On Wed, Mar 28, 2018 at 8:26 AM, Shea Levy <shea@shealevy.com> wrote:
>> Now only those architectures that have custom initrd free requirements
>> need to define free_initrd_mem.
>>
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>
>Yay consolidation! :)
>
>> --- a/usr/Kconfig
>> +++ b/usr/Kconfig
>> @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION
>>         default ".lzma" if RD_LZMA
>>         default ".bz2"  if RD_BZIP2
>>         default ""
>> +
>> +config HAVE_ARCH_FREE_INITRD_MEM
>> +       bool
>> +       default n
>
>If you keep the Kconfig, you can leave off "default n", and I'd
>suggest adding a help section just to describe what the per-arch
>responsibilities are when select-ing the config. (See
>HAVE_ARCH_SECCOMP_FILTER for an example.)
>

One question about this change.

The original code would "select" HAVE_ARCH_FREE_INITRD_MEM on those arch.
After this change, we need to manually "select" this?

>-Kees
>
>-- 
>Kees Cook
>Pixel Security

-- 
Wei Yang
Help you, Help me

  reply	other threads:[~2018-03-29  1:12 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24 17:44 [PATCH 00/16] Generic infrastructure for unloading initramfs Shea Levy
2018-03-24 17:44 ` [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic Shea Levy
2018-03-25 17:17   ` LEROY Christophe
2018-03-25 22:20     ` Shea Levy
2018-03-28 12:04   ` Christoph Hellwig
2018-03-28 12:23     ` Geert Uytterhoeven
2018-03-24 17:44 ` [PATCH 02/16] riscv: Use INITRAMFS_GENERIC_UNLOAD Shea Levy
2018-03-24 17:44 ` [PATCH 03/16] alpha: " Shea Levy
2018-03-24 17:44 ` [PATCH 04/16] arc: " Shea Levy
2018-03-24 17:44 ` [PATCH 05/16] c6x: " Shea Levy
2018-03-24 17:44 ` [PATCH 06/16] frv: " Shea Levy
2018-03-24 17:44 ` [PATCH 07/16] h8300: " Shea Levy
2018-03-24 17:44 ` [PATCH 08/16] m32r: " Shea Levy
2018-03-24 17:44 ` [PATCH 09/16] m68k: " Shea Levy
2018-03-24 17:44 ` [PATCH 10/16] microblaze: " Shea Levy
2018-03-24 17:44 ` [PATCH 11/16] nios2: " Shea Levy
2018-03-24 17:44 ` [PATCH 12/16] openrisc: " Shea Levy
2018-03-24 17:44 ` [PATCH 13/16] parisc: " Shea Levy
2018-03-24 17:44 ` [PATCH 14/16] powerpc: " Shea Levy
2018-03-24 17:44 ` [PATCH 15/16] sh: " Shea Levy
2018-03-24 17:44 ` [PATCH 16/16] um: " Shea Levy
2018-03-25 22:18 ` [PATCH v2 00/16] Generic infrastructure for unloading initramfs Shea Levy
2018-03-25 22:18   ` [PATCH v2 01/16] initrd: Add generic code path for common initrd unloading logic Shea Levy
2018-03-25 22:18   ` [PATCH v2 02/16] riscv: Use INITRAMFS_GENERIC_UNLOAD Shea Levy
2018-03-26  0:41     ` Palmer Dabbelt
2018-03-26  0:55       ` Shea Levy
2018-03-25 22:18   ` [PATCH v2 03/16] alpha: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 04/16] arc: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 05/16] c6x: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 06/16] frv: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 07/16] h8300: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 08/16] m32r: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 09/16] m68k: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 10/16] microblaze: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 11/16] nios2: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 12/16] openrisc: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 13/16] parisc: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 14/16] powerpc: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 15/16] sh: " Shea Levy
2018-03-25 22:18   ` [PATCH v2 16/16] um: " Shea Levy
2018-03-28 15:26   ` [PATCH] Extract initrd free logic from arch-specific code Shea Levy
2018-03-28 15:58     ` Rob Landley
2018-03-28 16:04       ` Shea Levy
2018-03-28 16:48       ` Russell King - ARM Linux
2018-03-28 19:04         ` Rob Landley
2018-03-28 22:14           ` Russell King - ARM Linux
2018-03-28 22:37             ` Oliver
2018-03-29  0:23               ` Nicholas Piggin
2018-03-29 15:27               ` Russell King - ARM Linux
2018-03-29 15:43                 ` Geert Uytterhoeven
2018-03-29 15:58                   ` Russell King - ARM Linux
2018-03-29 16:53                     ` Marc Zyngier
2018-03-29 17:32                       ` Russell King - ARM Linux
2018-03-29 17:53                         ` Marc Zyngier
2018-03-29 17:43                 ` Rob Landley
2018-03-29 16:39             ` Rob Landley
2018-03-29 17:31               ` Russell King - ARM Linux
2018-03-28 16:55     ` Kees Cook
2018-03-29  1:12       ` Wei Yang [this message]
2018-03-28 20:36     ` [PATCH v4 0/16] Generic initrd_free_mem Shea Levy
2018-03-28 20:36       ` [PATCH v4 01/16] initrd: Add weakly-linked generic free_initrd_mem Shea Levy
2018-03-28 20:36       ` [PATCH v4 02/16] riscv: Use " Shea Levy
2018-03-29  9:52         ` Daniel Thompson
2018-03-29 11:12           ` Shea Levy
2018-03-28 20:36       ` [PATCH v4 03/16] alpha: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 04/16] arc: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 05/16] c6x: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 06/16] frv: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 07/16] h8300: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 08/16] m32r: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 09/16] m68k: " Shea Levy
2018-03-29  6:55         ` Geert Uytterhoeven
2018-03-28 20:36       ` [PATCH v4 10/16] microblaze: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 11/16] nios2: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 12/16] openrisc: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 13/16] parisc: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 14/16] powerpc: " Shea Levy
2018-03-28 20:44         ` Joe Perches
2018-03-28 20:53           ` Shea Levy
2018-03-29 13:19             ` Michael Ellerman
2018-04-01 15:01               ` Shea Levy
2018-03-28 20:36       ` [PATCH v4 15/16] sh: " Shea Levy
2018-03-28 20:36       ` [PATCH v4 16/16] um: " Shea Levy
2018-03-29 11:31       ` [PATCH v5 01/16] initrd: Add weakly-linked " Shea Levy
2018-03-29 11:31         ` [PATCH v5 02/16] riscv: Free initrds with " Shea Levy
2018-03-29 11:31         ` [PATCH v5 03/16] alpha: Switch to " Shea Levy
2018-03-29 11:31         ` [PATCH v5 04/16] arc: " Shea Levy
2018-03-29 11:31         ` [PATCH v5 05/16] c6x: " Shea Levy
2018-03-29 11:31         ` [PATCH v5 06/16] frv: " Shea Levy
2018-03-29 11:31         ` [PATCH v5 07/16] h8300: " Shea Levy
2018-03-29 11:31         ` [PATCH v5 08/16] m32r: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 09/16] m68k: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 10/16] microblaze: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 11/16] nios2: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 12/16] openrisc: " Shea Levy
2018-03-29 11:50           ` Stafford Horne
2018-03-29 11:32         ` [PATCH v5 13/16] parisc: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 14/16] powerpc: " Shea Levy
2018-03-29 11:32         ` [PATCH v5 15/16] sh: " Shea Levy
2018-03-29 16:26           ` Rich Felker
2018-03-29 11:32         ` [PATCH v5 16/16] um: " Shea Levy
2018-04-01 14:59         ` [PATCH v6 01/16] initrd: Add weakly-linked " Shea Levy
2018-04-01 14:59           ` [PATCH v6 02/16] riscv: Free initrds with " Shea Levy
2018-04-01 14:59           ` [PATCH v6 03/16] alpha: Switch to " Shea Levy
2018-04-01 14:59           ` [PATCH v6 04/16] arc: " Shea Levy
2018-04-04 15:21             ` Alexey Brodkin
2018-04-09 16:40             ` Vineet Gupta
2018-04-01 14:59           ` [PATCH v6 05/16] c6x: " Shea Levy
2018-04-19 16:37             ` Mark Salter
2018-04-01 14:59           ` [PATCH v6 06/16] frv: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 07/16] h8300: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 08/16] m32r: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 09/16] m68k: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 10/16] microblaze: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 11/16] nios2: " Shea Levy
2018-04-02 16:04             ` Ley Foon Tan
2018-04-01 14:59           ` [PATCH v6 12/16] openrisc: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 13/16] parisc: " Shea Levy
2018-04-02 20:07             ` Helge Deller
2018-04-01 14:59           ` [PATCH v6 14/16] powerpc: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 15/16] sh: " Shea Levy
2018-04-01 14:59           ` [PATCH v6 16/16] um: " Shea Levy
2018-04-18 11:10           ` [PATCH v6 01/16] initrd: Add weakly-linked " Shea Levy
2018-04-20 20:22             ` Palmer Dabbelt
2018-04-20 22:50               ` Shea Levy
2018-05-09 11:15                 ` Shea Levy
2018-03-30  1:43     ` [PATCH] Extract initrd free logic from arch-specific code kbuild test robot
2018-03-30  3:16     ` kbuild test robot
2018-03-30 11:15     ` Ingo Molnar
2018-04-01 15:05       ` Shea Levy
2018-04-02  5:59         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329011210.GA4275@WeideMacBook-Pro.local \
    --to=richard.weiyang@gmail.com \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).