From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures
Date: Thu, 2 Aug 2018 04:37:27 -0700 [thread overview]
Message-ID: <20180802113727.GB17108@infradead.org> (raw)
In-Reply-To: <1533188391-5932-3-git-send-email-alankao@andestech.com>
s/codes/code/ in the subject. Also a little explanation of why
you refactor it in the patch description would be helpful.
> +static long restore_fp_state(struct pt_regs *regs,
> + union __riscv_fp_state *sc_fpregs)
Please add another tab for the indentation here even if the original
code got it wrong.
> +static long save_fp_state(struct pt_regs *regs,
> + union __riscv_fp_state *sc_fpregs)
Same here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-08-02 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 5:39 [PATCH v3 0/4] riscv: Add support to no-FPU systems Alan Kao
2018-08-02 5:39 ` [PATCH v3 1/4] Extract FPU context operations from entry.S Alan Kao
2018-08-02 11:35 ` Christoph Hellwig
2018-08-02 5:39 ` [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures Alan Kao
2018-08-02 11:37 ` Christoph Hellwig [this message]
2018-08-03 6:42 ` kbuild test robot
2018-08-02 5:39 ` [PATCH v3 3/4] Cleanup ISA string setting Alan Kao
2018-08-02 11:38 ` Christoph Hellwig
2018-08-02 5:39 ` [PATCH v3 4/4] Add an option to support no-FPU systems Alan Kao
2018-08-02 11:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802113727.GB17108@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).