From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v3 4/4] Add an option to support no-FPU systems
Date: Thu, 2 Aug 2018 04:41:48 -0700 [thread overview]
Message-ID: <20180802114148.GD17108@infradead.org> (raw)
In-Reply-To: <1533188391-5932-5-git-send-email-alankao@andestech.com>
On Thu, Aug 02, 2018 at 01:39:51PM +0800, Alan Kao wrote:
> FP codes have been separated from common part in previous patches.
> This patch add the CONFIG_FPU option and some stubs to support
> no-FPU systems.
I think the subject should be 'allow to disable FPU support'.
As discussed in the other thread we should be able to detect
systems without FPU and handle them fine even with FPU support built
in. Even with that I think this patch is otherwise fine and the
detection can be layered on top. One more nitpick below:
> +#else
> +#define save_fp_state(task, regs) (0)
> +#define restore_fp_state(task, regs) (0)
> +#define fstate_save(task, regs) do { } while (0)
> +#define fstate_restore(task, regs) do { } while (0)
> +#define __switch_to_aux(__prev, __next) do { } while (0)
> +#define DEFAULT_SSTATUS (SR_SPIE | SR_FS_OFF)
> +#endif
Please move the stubs for functions that are static in signal.c
into signal.c as well - you already have a CONFIG_FPU ifdef block
in that file anyway.
prev parent reply other threads:[~2018-08-02 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 5:39 [PATCH v3 0/4] riscv: Add support to no-FPU systems Alan Kao
2018-08-02 5:39 ` [PATCH v3 1/4] Extract FPU context operations from entry.S Alan Kao
2018-08-02 11:35 ` Christoph Hellwig
2018-08-02 5:39 ` [PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures Alan Kao
2018-08-02 11:37 ` Christoph Hellwig
2018-08-03 6:42 ` kbuild test robot
2018-08-02 5:39 ` [PATCH v3 3/4] Cleanup ISA string setting Alan Kao
2018-08-02 11:38 ` Christoph Hellwig
2018-08-02 5:39 ` [PATCH v3 4/4] Add an option to support no-FPU systems Alan Kao
2018-08-02 11:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802114148.GD17108@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).