linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v5 5/5] Auto-detect whether a FPU exists
Date: Wed, 8 Aug 2018 23:31:24 -0700	[thread overview]
Message-ID: <20180809063124.GA26062@infradead.org> (raw)
In-Reply-To: <1533796003-680-6-git-send-email-alankao@andestech.com>

>  extern unsigned long elf_hwcap;
> +extern bool has_fpu;
>  #endif

Doesn't this conflict with the !CONFIG_CPU stub in switch_to.h?

It seems like we should only have this definition in one place to start
with.

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-08-09  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  6:26 [PATCH v5 0/5] riscv: Add support to no-FPU systems Alan Kao
2018-08-09  6:26 ` [PATCH v5 1/5] Extract FPU context operations from entry.S Alan Kao
2018-08-09  6:26 ` [PATCH v5 2/5] Refactor FPU code in signal setup/return procedures Alan Kao
2018-08-09  6:26 ` [PATCH v5 3/5] Cleanup ISA string setting Alan Kao
2018-08-09  6:26 ` [PATCH v5 4/5] Allow to disable FPU support Alan Kao
2018-08-09  6:26 ` [PATCH v5 5/5] Auto-detect whether a FPU exists Alan Kao
2018-08-09  6:31   ` Christoph Hellwig [this message]
2018-08-09  6:43     ` Alan Kao
2018-08-09  7:02       ` Christoph Hellwig
2018-08-09  7:33         ` Alan Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809063124.GA26062@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).