linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anup@brainfault.org (Anup Patel)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 2/5] RISC-V: No need to pass scause as arg to do_IRQ()
Date: Thu,  6 Sep 2018 18:06:48 +0530	[thread overview]
Message-ID: <20180906123651.28500-3-anup@brainfault.org> (raw)
In-Reply-To: <20180906123651.28500-1-anup@brainfault.org>

The scause is already part of pt_regs so no need to pass
scause as separate arg to do_IRQ().

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anup Patel <anup@brainfault.org>
---
 arch/riscv/kernel/entry.S | 1 -
 arch/riscv/kernel/irq.c   | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S
index fa2c08e3c05e..6eaacfa5b63d 100644
--- a/arch/riscv/kernel/entry.S
+++ b/arch/riscv/kernel/entry.S
@@ -168,7 +168,6 @@ ENTRY(handle_exception)
 
 	/* Handle interrupts */
 	move a0, sp /* pt_regs */
-	move a1, s4 /* scause */
 	tail do_IRQ
 1:
 	/* Exceptions run with interrupts enabled */
diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
index f5073dcbc560..d0de40e1e7f3 100644
--- a/arch/riscv/kernel/irq.c
+++ b/arch/riscv/kernel/irq.c
@@ -24,11 +24,11 @@
  */
 #define INTERRUPT_CAUSE_FLAG	(1UL << (__riscv_xlen - 1))
 
-asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs, unsigned long cause)
+asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs)
 {
 	struct pt_regs *old_regs;
 
-	switch (cause & ~INTERRUPT_CAUSE_FLAG) {
+	switch (regs->scause & ~INTERRUPT_CAUSE_FLAG) {
 	case INTERRUPT_CAUSE_TIMER:
 		old_regs = set_irq_regs(regs);
 		irq_enter();
-- 
2.17.1

  parent reply	other threads:[~2018-09-06 12:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 12:36 [PATCH v2 0/5] New RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-06 12:36 ` [PATCH v2 1/5] RISC-V: self-contained IPI handling routine Anup Patel
2018-09-06 12:36 ` Anup Patel [this message]
2018-09-06 12:36 ` [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-06 14:06   ` Christoph Hellwig
2018-09-06 14:19     ` Anup Patel
2018-09-08 10:46     ` Thomas Gleixner
2018-09-10 13:29       ` Christoph Hellwig
2018-09-10 13:34         ` Thomas Gleixner
2018-09-10 13:37           ` Thomas Gleixner
2018-09-10 13:39             ` Christoph Hellwig
2018-09-10 13:45               ` Thomas Gleixner
2018-09-10 13:49                 ` Christoph Hellwig
2018-09-10 14:29                   ` Anup Patel
2018-09-10 16:07                     ` Thomas Gleixner
2018-09-10 16:11                       ` Christoph Hellwig
2018-09-10 16:35                         ` Anup Patel
2018-09-10 16:39                           ` Christoph Hellwig
2018-09-10 17:11                             ` Anup Patel
2018-09-10 19:37                               ` Thomas Gleixner
2018-09-10 22:19                                 ` Christoph Hellwig
2018-09-11  3:57                                   ` Anup Patel
2018-09-11  6:22                                     ` Christoph Hellwig
2018-09-10 22:16                               ` Christoph Hellwig
2018-09-10 16:13                     ` Christoph Hellwig
2018-09-10 16:32                       ` Anup Patel
2018-09-10 16:35                         ` Christoph Hellwig
2018-09-10 16:38                           ` Anup Patel
2018-09-17 14:14                             ` Christoph Hellwig
2018-09-17 14:28                               ` Anup Patel
2018-09-26  5:54                                 ` Anup Patel
2018-09-26  5:54                                   ` Anup Patel
2018-09-26 15:38                                   ` Palmer Dabbelt
2018-09-26 15:38                                     ` Palmer Dabbelt
2018-09-06 12:36 ` [PATCH v2 4/5] clocksource: riscv_timer: Make timer interrupt as a per-CPU interrupt Anup Patel
2018-09-06 12:36 ` [PATCH v2 5/5] RISC-V: Remove do_IRQ() function Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906123651.28500-3-anup@brainfault.org \
    --to=anup@brainfault.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).