linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anup@brainfault.org (Anup Patel)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 5/5] RISC-V: Remove do_IRQ() function
Date: Thu,  6 Sep 2018 18:06:51 +0530	[thread overview]
Message-ID: <20180906123651.28500-6-anup@brainfault.org> (raw)
In-Reply-To: <20180906123651.28500-1-anup@brainfault.org>

The only thing do_IRQ() does is call handle_arch_irq function
pointer. We can very well call handle_arch_irq function pointer
directly from assembly and remove do_IRQ() function hence this
patch.

Signed-off-by: Anup Patel <anup@brainfault.org>
---
 arch/riscv/kernel/entry.S | 4 +++-
 arch/riscv/kernel/irq.c   | 6 ------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S
index 6eaacfa5b63d..69fbe9dd9e0c 100644
--- a/arch/riscv/kernel/entry.S
+++ b/arch/riscv/kernel/entry.S
@@ -168,7 +168,9 @@ ENTRY(handle_exception)
 
 	/* Handle interrupts */
 	move a0, sp /* pt_regs */
-	tail do_IRQ
+	la a1, handle_arch_irq
+	REG_L a1, (a1)
+	jr a1
 1:
 	/* Exceptions run with interrupts enabled */
 	csrs sstatus, SR_SIE
diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c
index 9ced284da30b..695e241d0402 100644
--- a/arch/riscv/kernel/irq.c
+++ b/arch/riscv/kernel/irq.c
@@ -8,12 +8,6 @@
 #include <linux/interrupt.h>
 #include <linux/irqchip.h>
 
-asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs)
-{
-	if (handle_arch_irq)
-		handle_arch_irq(regs);
-}
-
 /*
  * This function doesn't return until a software interrupt is sent via IPI.
  * Obviously, all the interrupts except software interrupt should be disabled
-- 
2.17.1

      parent reply	other threads:[~2018-09-06 12:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 12:36 [PATCH v2 0/5] New RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-06 12:36 ` [PATCH v2 1/5] RISC-V: self-contained IPI handling routine Anup Patel
2018-09-06 12:36 ` [PATCH v2 2/5] RISC-V: No need to pass scause as arg to do_IRQ() Anup Patel
2018-09-06 12:36 ` [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-06 14:06   ` Christoph Hellwig
2018-09-06 14:19     ` Anup Patel
2018-09-08 10:46     ` Thomas Gleixner
2018-09-10 13:29       ` Christoph Hellwig
2018-09-10 13:34         ` Thomas Gleixner
2018-09-10 13:37           ` Thomas Gleixner
2018-09-10 13:39             ` Christoph Hellwig
2018-09-10 13:45               ` Thomas Gleixner
2018-09-10 13:49                 ` Christoph Hellwig
2018-09-10 14:29                   ` Anup Patel
2018-09-10 16:07                     ` Thomas Gleixner
2018-09-10 16:11                       ` Christoph Hellwig
2018-09-10 16:35                         ` Anup Patel
2018-09-10 16:39                           ` Christoph Hellwig
2018-09-10 17:11                             ` Anup Patel
2018-09-10 19:37                               ` Thomas Gleixner
2018-09-10 22:19                                 ` Christoph Hellwig
2018-09-11  3:57                                   ` Anup Patel
2018-09-11  6:22                                     ` Christoph Hellwig
2018-09-10 22:16                               ` Christoph Hellwig
2018-09-10 16:13                     ` Christoph Hellwig
2018-09-10 16:32                       ` Anup Patel
2018-09-10 16:35                         ` Christoph Hellwig
2018-09-10 16:38                           ` Anup Patel
2018-09-17 14:14                             ` Christoph Hellwig
2018-09-17 14:28                               ` Anup Patel
2018-09-26  5:54                                 ` Anup Patel
2018-09-26  5:54                                   ` Anup Patel
2018-09-26 15:38                                   ` Palmer Dabbelt
2018-09-26 15:38                                     ` Palmer Dabbelt
2018-09-06 12:36 ` [PATCH v2 4/5] clocksource: riscv_timer: Make timer interrupt as a per-CPU interrupt Anup Patel
2018-09-06 12:36 ` Anup Patel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906123651.28500-6-anup@brainfault.org \
    --to=anup@brainfault.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).