From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Mon, 10 Sep 2018 04:25:48 -0700 Subject: [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid In-Reply-To: <1536221135-182613-7-git-send-email-atish.patra@wdc.com> References: <1536221135-182613-1-git-send-email-atish.patra@wdc.com> <1536221135-182613-7-git-send-email-atish.patra@wdc.com> Message-ID: <20180910112548.GF12979@infradead.org> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org On Thu, Sep 06, 2018 at 01:05:29AM -0700, Atish Patra wrote: > From: Palmer Dabbelt > > It's a bit confusing exactly what this function does: it actually > returns the hartid of an OF processor node, failing with -1 on invalid > nodes. I've changed the name to _hartid() in order to make that a bit > more clear, as well as adding a comment. > > Signed-off-by: Palmer Dabbelt Looks generally good, but it is going to conflict with the dt iterators series from Rob. Given that this is just a little cleanup it might be worth deferring until the next merge window. Otherwise looks good: Reviewed-by: Christoph Hellwig