From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] RISC-V: include linux/ftrace.h in asm-prototypes.h
Date: Thu, 20 Sep 2018 23:44:10 -0700 [thread overview]
Message-ID: <20180921064410.GA26810@infradead.org> (raw)
In-Reply-To: <20180910112306.GA12979@infradead.org>
On Mon, Sep 10, 2018 at 04:23:06AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 06, 2018 at 10:57:56PM +0100, James Cowgill wrote:
> > When exporting symbols from an assembly file, the MODVERSIONS code
> > requires their prototypes to be defined in asm-prototypes.h (see
> > scripts/Makefile.build). Since both of these symbols have prototypes
> > defined in linux/ftrace.h, include this header from RISC-V's
> > asm-prototypes.h.
> >
> > Reported-by: Karsten Merker <merker@debian.org>
> > Signed-off-by: James Cowgill <jcowgill@debian.org>
>
> I think this needs at very least a good comment, including for which
> symbols you are doing this.
>
> Also I'm curious if it might be worth just handling this in the
> asm-generic version, as those symbols should be assembly exports
> in most architectures.
Ok, looks like we don't really need the asm-generic asm-prototypes.h
to start with as far as I can tell. So I think you can resubmit it
with just the ftrace.h include and a comment.
prev parent reply other threads:[~2018-09-21 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 21:57 [PATCH] RISC-V: include linux/ftrace.h in asm-prototypes.h James Cowgill
2018-09-10 11:23 ` Christoph Hellwig
2018-09-21 6:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921064410.GA26810@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).