From mboxrd@z Thu Jan 1 00:00:00 1970 From: rppt@linux.vnet.ibm.com (Mike Rapoport) Date: Wed, 26 Sep 2018 21:31:53 +0300 Subject: [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK In-Reply-To: References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-4-git-send-email-rppt@linux.vnet.ibm.com> Message-ID: <20180926183152.GA4597@rapoport-lnx> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org On Wed, Sep 26, 2018 at 09:58:41AM -0700, Alexander Duyck wrote: > On Fri, Sep 14, 2018 at 5:11 AM Mike Rapoport wrote: > > > > All architecures use memblock for early memory management. There is no need > > for the CONFIG_HAVE_MEMBLOCK configuration option. > > > > Signed-off-by: Mike Rapoport > > > > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > > index 5169205..4ae91fc 100644 > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > @@ -2,7 +2,6 @@ > > #define _LINUX_MEMBLOCK_H > > #ifdef __KERNEL__ > > > > -#ifdef CONFIG_HAVE_MEMBLOCK > > /* > > * Logical memory blocks. > > * > > @@ -460,7 +459,6 @@ static inline phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align) > > { > > return 0; > > } > > -#endif /* CONFIG_HAVE_MEMBLOCK */ > > > > #endif /* __KERNEL__ */ > > There was an #else above this section and I believe it and the code > after it needs to be stripped as well. Right, I've already sent the fix [1] and it's in mmots. [1] https://lkml.org/lkml/2018/9/19/416 -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBE9ECE560 for ; Wed, 26 Sep 2018 18:34:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F87A2152C for ; Wed, 26 Sep 2018 18:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rXJzpyAF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F87A2152C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version: References:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eaoVctNkZxb2JqM3YV7UutAWJ1dy6YLq879nY2Rb1so=; b=rXJzpyAFtFhfT8 jsjxqkVQCczry1e1b4Z+m+RZT3BHA7Ziw1BqFNQs5Wc6UwZXlj116Et0JT3zHxKUaNwCE6gsSxRrc gP9UMPxJaD253MdOdA7x5OHC7IrBVZGgWMWax7B1Gp+Krvlz8mmntq0fldWIgZ3XM19aULkD5zBTB PO51hp5n7YCIMCgeclLB3ycRwGqZG6xHYHGIWC+0H0FzTtdx6/xqO9Moe2y3kviYd9Fe27lZCeeeP MrnjtgjsQlYcU8Ofj+Ucvod4FtY7E/UlOGwrxemNPkwkrOYdi8F3RC9rGGykpYX0AZ+jFDEL3JWDH 3oFCLlC67F/iDzuLpT4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5EdE-0001WE-1K; Wed, 26 Sep 2018 18:33:52 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g5EcA-0001Pe-Av for linux-riscv@lists.infradead.org; Wed, 26 Sep 2018 18:32:50 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8QIT9Kn020905 for ; Wed, 26 Sep 2018 14:32:15 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2mrf5kruxm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 26 Sep 2018 14:32:14 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2018 19:32:12 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 26 Sep 2018 19:32:00 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8QIVxwW65994892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Sep 2018 18:31:59 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 826B4A405D; Wed, 26 Sep 2018 21:31:40 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C9ACA4040; Wed, 26 Sep 2018 21:31:36 +0100 (BST) Received: from rapoport-lnx (unknown [9.148.204.125]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 26 Sep 2018 21:31:35 +0100 (BST) Date: Wed, 26 Sep 2018 21:31:53 +0300 From: Mike Rapoport To: Alexander Duyck Subject: Re: [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK References: <1536927045-23536-1-git-send-email-rppt@linux.vnet.ibm.com> <1536927045-23536-4-git-send-email-rppt@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18092618-0020-0000-0000-000002CBF8A0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092618-0021-0000-0000-0000211A1CA6 Message-Id: <20180926183152.GA4597@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-09-26_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809260172 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180926_113246_551026_05F336D5 X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Michal Hocko , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , palmer@sifive.com, Russell King - ARM Linux , linux-mm , dalias@libc.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, jonas@southpole.se, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Jonathan Corbet , mpe@ellerman.id.au, jejb@parisc-linux.org, Ingo Molnar , Geert Uytterhoeven , msalter@redhat.com, mattst88@gmail.com, linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, green.hu@gmail.com, nios2-dev@lists.rocketboards.org, Thomas Gleixner , gxt@pku.edu.cn, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, Tony Luck , linux-parisc@vger.kernel.org, Greg KH , LKML , fancer.lancer@gmail.com, rkuo@codeaurora.org, paul.burton@mips.com, vgupta@synopsys.com, richard@nod.at, Martin Schwidefsky , lftan@altera.com, Andrew Morton , "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , David Miller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Message-ID: <20180926183153.IehX2rO0idkg3g0ZGYCbrkpL-8I97zifaKjW4lJdtLs@z> On Wed, Sep 26, 2018 at 09:58:41AM -0700, Alexander Duyck wrote: > On Fri, Sep 14, 2018 at 5:11 AM Mike Rapoport wrote: > > > > All architecures use memblock for early memory management. There is no need > > for the CONFIG_HAVE_MEMBLOCK configuration option. > > > > Signed-off-by: Mike Rapoport > > > > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > > index 5169205..4ae91fc 100644 > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > @@ -2,7 +2,6 @@ > > #define _LINUX_MEMBLOCK_H > > #ifdef __KERNEL__ > > > > -#ifdef CONFIG_HAVE_MEMBLOCK > > /* > > * Logical memory blocks. > > * > > @@ -460,7 +459,6 @@ static inline phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align) > > { > > return 0; > > } > > -#endif /* CONFIG_HAVE_MEMBLOCK */ > > > > #endif /* __KERNEL__ */ > > There was an #else above this section and I believe it and the code > after it needs to be stripped as well. Right, I've already sent the fix [1] and it's in mmots. [1] https://lkml.org/lkml/2018/9/19/416 -- Sincerely yours, Mike. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv