From: Christoph Hellwig <hch@infradead.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com,
robh+dt@kernel.org, thierry.reding@gmail.com,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM
Date: Tue, 15 Jan 2019 07:27:57 -0800 [thread overview]
Message-ID: <20190115152757.GB26443@infradead.org> (raw)
In-Reply-To: <1547194964-16718-3-git-send-email-yash.shah@sifive.com>
From a general code quality point of view this looks fine to me.
I don't really know anything about the PWM subsystem, though:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-01-15 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:22 [PATCH 0/2] PWM support for HiFive Unleashed Yash Shah
2019-01-11 8:22 ` [PATCH 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller Yash Shah
2019-01-15 20:11 ` Uwe Kleine-König
2019-01-16 9:21 ` Yash Shah
2019-01-21 11:20 ` Thierry Reding
2019-01-11 8:22 ` [PATCH 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Yash Shah
2019-01-15 15:27 ` Christoph Hellwig [this message]
2019-01-15 22:00 ` Uwe Kleine-König
2019-01-16 11:10 ` Yash Shah
2019-01-16 16:46 ` Uwe Kleine-König
2019-01-16 17:18 ` Paul Walmsley
2019-01-16 17:28 ` Uwe Kleine-König
2019-01-16 19:29 ` Paul Walmsley
2019-01-17 8:19 ` Uwe Kleine-König
2019-01-21 11:54 ` Thierry Reding
2019-01-21 15:11 ` Uwe Kleine-König
2019-01-17 6:45 ` Yash Shah
2019-01-17 7:28 ` Uwe Kleine-König
2019-01-21 11:30 ` Thierry Reding
2019-01-21 13:23 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115152757.GB26443@infradead.org \
--to=hch@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=thierry.reding@gmail.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).