Re: [PATCH 0/3] Hugetlbfs support for riscv

Alex Ghiti
2019-01-15T18:56:38Z

On 1/15/19 4:04 PM, Christoph Hellwig wrote:
> On Wed, Jan 09, 2019 at 11:23:22AM -0800, Mike Kravetz wrote:
>>> CMA or (MEMORY_ISOLATION && COMPACTION) must be enabled so that boot
>>> reserved gigantic pages can be freed: indeed, one can reduce the number
>>> of huge pages by calling free_gigantic_pages which in turn calls
>>> free_contig_range, defined only with those configs defined.
>>> However I don't see any strong dependency between free_contig_range
>>> and those configs, maybe we could allow hugetlbfs users to free boot
>>> reserved hugepages without those configs activated, I will propose
>>> something if Mike Kravetz agrees.
>> Yes, that should be modified. I think it would be a simple matter of moving
>> free_contig_range out of that ifdef block. If you would like, I can submit
>> a patch for that.
> We should probably include that patch in this series.

Ok, the patch for this is ready, I will include it in the series with your
comments.

Thanks again for your reviews,

Alex

>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv