Re: [PATCH 0/3] Hugetlbfs support for riscv

Christoph Hellwig
2019-01-15T20:52:52Z

On Tue, Jan 15, 2019 at 11:25:07AM -0800, Mike Kravetz wrote:
> I would actually prefer that this be a separate patch. Why?
> - The functionality is arch independent and not specific to riscv.
> - This functionality was intended in commit 944d9fec8d7a ("hugetlb:
> add support for gigantic page allocation at runtime"). However,
> there was no need to tie the functionality to CMA or (MEMORY_ISOLATION
> && COMPACTION).
>
> I don't care enough to insist the patch be separate. Just seems like
> it should be separate to me.

Oh, I agree it should be a separate patch. But it would be nice to
merge it together with the RISC-V hugetlb support, so that it can
depend on the patch instead of the current somewhat odd Kconfig
dependencies.