From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB93C43381 for ; Mon, 25 Mar 2019 14:55:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AA3D20811 for ; Mon, 25 Mar 2019 14:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="joln9Idv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AA3D20811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cL6vG8r2s1kxHz1u6Y6n9ORvVm7HhypcXrX1moEpUQY=; b=joln9Idv05IJ1s K7EhpY+krMYT1ecvFtgFM36s5ibax8SsVOYfQXu1kO+UykZAqijbHbXYfeFhJml+lISmBGa85HepF GfXqNvtHrsw159Zd0ppxp7qz2+cPrs3SHC/vf5MoMKnbOYQlH/xbsfrWoNZ3/3THsB+lr57pzXg3S OMLHOI1jHqJSapM6+WxOY+zN4qdcAVMReTkeBPqDSKYVv7IxvW3EbzH1/YbKV44Ph6HrbfHVeITqT zmuy989w8z67Fy8HHp4qqCcYCek8sPNQOBymA0inhG6N6PvUUEzUpWoosLmR1J6J+Vcyhz0V6HiWf OBB/OTPsVMEkVyXATTCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8R0t-0005EP-Tu; Mon, 25 Mar 2019 14:55:47 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8R0q-0005Da-1o; Mon, 25 Mar 2019 14:55:44 +0000 Date: Mon, 25 Mar 2019 07:55:43 -0700 From: Christoph Hellwig To: Anup Patel Subject: Re: [PATCH v3 4/4] RISC-V: Allow booting kernel from any 4KB aligned address Message-ID: <20190325145543.GA14826@infradead.org> References: <20190325092234.5451-1-anup.patel@wdc.com> <20190325092234.5451-5-anup.patel@wdc.com> <20190325113935.GD27843@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Palmer Dabbelt , Anup Patel , "linux-kernel@vger.kernel.org" , Mike Rapoport , Christoph Hellwig , Atish Patra , Albert Ou , Paul Walmsley , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 06:12:28PM +0530, Anup Patel wrote: > It uses new code for 2M mappings as well. That seems to be an odd view - yes some code is shared, but we still have two different ways using ifdefs. > The code is lot better, readable and flexible. better is in the eye of the beholder. It very much is not easier readable with the spurious indirect calls at least. And it is a lot bigger. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv