From: Christoph Hellwig <hch@infradead.org>
To: Vincent Chen <vincent.chen@sifive.com>
Cc: linux-riscv@lists.infradead.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
paul.walmsley@sifive.com
Subject: Re: [PATCH 2/2] riscv: Make __fstate_clean() can work correctly.
Date: Mon, 12 Aug 2019 07:59:28 -0700 [thread overview]
Message-ID: <20190812145928.GE26897@infradead.org> (raw)
In-Reply-To: <1565251121-28490-3-git-send-email-vincent.chen@sifive.com>
Maybe s/can //g in the subject?
> + regs->sstatus = (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN;
No need for the inner braces here either.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-12 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:58 [PATCH 0/2] riscv: Correct the initialized flow of FP and __fstate_clean() Vincent Chen
2019-08-08 7:58 ` [PATCH 1/2] riscv: Correct the initialized flow of FP register Vincent Chen
2019-08-08 10:15 ` Anup Patel
2019-08-08 15:50 ` Paul Walmsley
2019-08-14 1:45 ` Vincent Chen
2019-08-14 3:51 ` Anup Patel
2019-08-12 14:58 ` Christoph Hellwig
2019-08-14 1:52 ` Vincent Chen
2019-08-08 7:58 ` [PATCH 2/2] riscv: Make __fstate_clean() can work correctly Vincent Chen
2019-08-08 10:17 ` Anup Patel
2019-08-14 1:55 ` Vincent Chen
2019-08-12 14:59 ` Christoph Hellwig [this message]
2019-08-14 1:55 ` Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812145928.GE26897@infradead.org \
--to=hch@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).