From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6D3CA9EA0 for ; Mon, 28 Oct 2019 08:12:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00C6B214AF for ; Mon, 28 Oct 2019 08:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KG+4U6cm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00C6B214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sp7ZMcwNgyKRvAo7gG2fGh5iSjRYsj4aYc8Nt1f5y7k=; b=KG+4U6cmGP9BKT 5ydT4oeH9rRH/1vWZFb6hdjnKq8BnJ+/jO2oGfGER/KxuRPTZXoznaMV/oqhlM0ys2j5Tqe73Gwo1 l2iX83VjJiS5XVSuZR9fEI1YzmpNsGHFpa3NYuy5mpgTaIm9NDU0ddzEJjzpmApz0spnF7L461uPb Qmeq8EN8qp4ksTq8KyCzbKVK/5EgPZMS5ezB5kiOc+GtSFwwid4FMKVW3QzKdPGIHRSc2+/mhFWym 6zDZlfI2onq758isv2BDIyCMMlmbGNgSd/7cohAtBF6EpfL2bjz3LvgLoBRNN+SUeRWFk0DHLNtIT /dyvLoT6tgjy4h6yvaQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP08v-0003Zv-Nu; Mon, 28 Oct 2019 08:12:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP08t-0003Z1-6f for linux-riscv@lists.infradead.org; Mon, 28 Oct 2019 08:12:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E8C9F68AFE; Mon, 28 Oct 2019 09:12:44 +0100 (CET) Date: Mon, 28 Oct 2019 09:12:44 +0100 From: Christoph Hellwig To: Paul Walmsley Subject: Re: [PATCH 03/15] riscv: abstract out CSR names for supervisor vs machine mode Message-ID: <20191028081244.GA20974@lst.de> References: <20191017173743.5430-1-hch@lst.de> <20191017173743.5430-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_011247_392696_825D9FF1 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Palmer Dabbelt , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 04:55:02PM -0700, Paul Walmsley wrote: > The basic idea looks good to me, but some of the X-prefixing can make the > code difficult to read. The Xret macro looks fine to me, as do the > XIE_XTIE macros. But I think it would be better if the X-prefixes on the > rest of the macros and structure members could be dropped. This also > aligns with the way that these registers often are discussed at the > architectural level; e.g., we'd talk about the "epc" registers, not the > "xepc" registers. If we get of the x we should get rid of all of them. I'll make sure it is all gone for the next version. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv