linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: Albert Ou <aou@eecs.berkeley.edu>,
	Atish Patra <atish.patra@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org, Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH v5 2/7] efi/libstub: Make initrd file loader configurable
Date: Wed, 22 Apr 2020 19:24:09 +0200	[thread overview]
Message-ID: <20200422172414.6662-3-ardb@kernel.org> (raw)
In-Reply-To: <20200422172414.6662-1-ardb@kernel.org>

Loading an initrd passed via the kernel command line is deprecated: it
is limited to files that reside in the same volume as the one the kernel
itself was loaded from, and we have more flexible ways to achieve the
same. So make it configurable so new architectures can decide not to
enable it.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/firmware/efi/Kconfig        | 11 +++++++++++
 drivers/firmware/efi/libstub/file.c |  3 +++
 2 files changed, 14 insertions(+)

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2a2b2b96a1dc..4e788dd55b03 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -124,6 +124,17 @@ config EFI_ARMSTUB_DTB_LOADER
 	  functionality for bootloaders that do not have such support
 	  this option is necessary.
 
+config EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
+	bool "Enable the command line initrd loader"
+	depends on EFI_GENERIC_STUB
+	default y
+	help
+	  Select this config option to add support for the initrd= command
+	  line parameter, allowing an initrd that resides on the same volume
+	  as the kernel image to be loaded into memory.
+
+	  This method is deprecated.
+
 config EFI_BOOTLOADER_CONTROL
 	tristate "EFI Bootloader Control"
 	depends on EFI_VARS
diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
index ea66b1f16a79..ccdc36aaaa97 100644
--- a/drivers/firmware/efi/libstub/file.c
+++ b/drivers/firmware/efi/libstub/file.c
@@ -254,6 +254,9 @@ efi_status_t efi_load_initrd(efi_loaded_image_t *image,
 			     unsigned long soft_limit,
 			     unsigned long hard_limit)
 {
+	if (!IS_ENABLED(CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER))
+		return EFI_SUCCESS;
+
 	return handle_cmdline_files(image, L"initrd=", sizeof(L"initrd=") - 2,
 				    soft_limit, hard_limit, load_addr, load_size);
 }
-- 
2.17.1



  parent reply	other threads:[~2020-04-22 17:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 17:24 [PATCH v5 0/7] Add UEFI support for RISC-V Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 1/7] efi/libstub: Move arm-stub to a common file Ard Biesheuvel
2020-04-22 17:24 ` Ard Biesheuvel [this message]
2020-06-16  7:55   ` [PATCH v5 2/7] efi/libstub: Make initrd file loader configurable Geert Uytterhoeven
2020-06-16  8:16     ` Ard Biesheuvel
2020-06-23 15:10       ` Geert Uytterhoeven
2020-04-22 17:24 ` [PATCH v5 3/7] efi/libstub/riscv: add arch specific efi.h header file Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 4/7] include: pe.h: Add RISC-V related PE definition Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 5/7] RISC-V: Define fixmap bindings for generic early ioremap support Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 6/7] RISC-V: Add PE/COFF header for EFI stub Ard Biesheuvel
2020-04-22 17:24 ` [PATCH v5 7/7] RISC-V: Add EFI stub support Ard Biesheuvel
2020-04-22 18:48   ` Atish Patra
2020-04-23 11:15     ` Ard Biesheuvel
2020-04-23 11:49       ` Ard Biesheuvel
2020-04-22 17:25 ` [PATCH v5 0/7] Add UEFI support for RISC-V Ard Biesheuvel
2020-04-22 18:50 ` Atish Patra
2020-04-23 22:43 ` Palmer Dabbelt
2020-04-24 11:08   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200422172414.6662-3-ardb@kernel.org \
    --to=ardb@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).