From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65EEC83004 for ; Wed, 29 Apr 2020 14:34:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBEAE206F0 for ; Wed, 29 Apr 2020 14:34:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cejJ2KpP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r0MyUrcN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBEAE206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D9eypSqOsC5XLm/gapdjFd3HLPSbUTz8znQDvYgjUjU=; b=cejJ2KpPY6HtWiFt8DeEHp6dK vUEPCRGEMaWp7bZueoxvwH8HoxSd3V+bNMqUCnp/E9aEL9GakjwksHiyKmV8FpSlmUYkCDO6mql0Z AaU4tWIvDiUr/hF40ZYhLzBJrGP5gVDgArVTIhQRoYHvz35ukZKk+oZHGjJxNPvu7yoA4bT3nWfVN PIbl/w12EX6DwX8MGuprLio2UArB4ApW8vfy2uU6kjudQL/oD/JhYZqj7PKens5q6Ot3YsObzei48 i778zeSV8fbZjsBT9e8vrbXIa2HFuy5sISRNKtYsQbLVCsa1pkNE0/r0sN93P6mtBkbJSNRnapM0s L/QL9jARA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTnn3-00008z-Ul; Wed, 29 Apr 2020 14:34:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTnmu-0008Uw-LU; Wed, 29 Apr 2020 14:34:19 +0000 Received: from kernel.org (unknown [87.70.161.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 796F52074A; Wed, 29 Apr 2020 14:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588170852; bh=WWPVYLJB8cF1eh/bgOa7kKMnwvq4kKVMrtpQ0105+PI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r0MyUrcNByfv40BqZMDUz9VgJFeWUeRjo2JW4VKDF1h/7I/qQIsmP3r+XczFilNcB ++CDc2aMtj2e1Vvw7mqelm0S/yNPEGrXgzqXPqqXmHsIltvr+DFp/+T/wSjD9ztS+C LzUl9esAqrKIQvImRO0XfT4341bJ3x0mFvf4a1wc= Date: Wed, 29 Apr 2020 17:33:46 +0300 From: Mike Rapoport To: Christoph Hellwig Subject: Re: [PATCH v2 16/20] mm: remove early_pfn_in_nid() and CONFIG_NODES_SPAN_OTHER_NODES Message-ID: <20200429143346.GI14260@kernel.org> References: <20200429121126.17989-1-rppt@kernel.org> <20200429121126.17989-17-rppt@kernel.org> <20200429141706.GA25142@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429141706.GA25142@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_073412_753958_29AFA563 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Heiko Carstens , x86@kernel.org, Michal Hocko , "James E.J. Bottomley" , Max Filippov , Guo Ren , Ley Foon Tan , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Greg Ungerer , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Baoquan He , Jonathan Corbet , linux-hexagon@vger.kernel.org, Helge Deller , linux-sh@vger.kernel.org, Russell King , linux-csky@vger.kernel.org, Mike Rapoport , Geert Uytterhoeven , Hoan Tran , Mark Salter , Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Nick Hu , linux-um@lists.infradead.org, linux-mips@vger.kernel.org, Richard Weinberger , linux-m68k@lists.linux-m68k.org, Thomas Bogendoerfer , Qian Cai , Greentime Hu , Paul Walmsley , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Michal Simek , Tony Luck , Yoshinori Sato , linux-parisc@vger.kernel.org, linux-mm@kvack.org, Vineet Gupta , Brian Cain , linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, linux-alpha@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 07:17:06AM -0700, Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 03:11:22PM +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > The commit f47ac088c406 ("mm: memmap_init: iterate over memblock regions > > rather that check each PFN") made early_pfn_in_nid() obsolete and since > > CONFIG_NODES_SPAN_OTHER_NODES is only used to pick a stub or a real > > implementation of early_pfn_in_nid() it is also not needed anymore. > > I don't think you can quote a commit id for something that hasn't been > commited to mainline yet.i Ouch, that was one of the things I've indented to fix in v2... > Then again I would have just merged this > patch into the one that obsoleted early_pfn_in_nid anyway. I've kept these commits separate to preserve the authorship. I'll update the changelog so that it won't mention commit id. -- Sincerely yours, Mike.