From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867C9C54E4B for ; Mon, 11 May 2020 11:00:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 590B820736 for ; Mon, 11 May 2020 11:00:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H5xrSXRV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 590B820736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c3HrU8T1M8DnyRyLa4V9UXUgSeC2OL6yP+RL8pl8kQM=; b=H5xrSXRVuki+0QmUPf8oGhqfB 13xtyTx/s4qcW4FSmoNmwo8IOQW4KiddYQe/1c32UmomyUVd/Qs2iBdMcLM8q2Ay0i9qmyaArj9IC ELk/azFVfG2+4HuEsn031H16yeodoXqR9oaET6cBg8QydBIvoy5IfmEHWk1Cplcfs1bU2ZEJ/ybWd 71V0VJJLRlz4aqJUc47S8DAx2n5r7HO+6ZL+kB6KnK/iuE54C6HI8955hFVqEQY6lDDJEonozsg3j tIz/th8fCWL18ZgAldECataXa+iYgK31oB0fwpDU9UxpKd5shQX2bczcdExuYOYannZvFIwddRKSP Nxv5rClTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY6Aq-00065s-10; Mon, 11 May 2020 11:00:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY6Ah-0005xH-PW; Mon, 11 May 2020 11:00:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4AD751FB; Mon, 11 May 2020 04:00:24 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DFC143F305; Mon, 11 May 2020 04:00:20 -0700 (PDT) Date: Mon, 11 May 2020 12:00:14 +0100 From: Catalin Marinas To: Will Deacon Subject: Re: [PATCH 02/31] arm64: fix the flush_icache_range arguments in machine_kexec Message-ID: <20200511110014.GA19176@gaia> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-3-hch@lst.de> <20200511075115.GA16134@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200511075115.GA16134@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_040031_872502_094B790F X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Roman Zippel , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Christoph Hellwig , linux-arch@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-xtensa@linux-xtensa.org, Arnd Bergmann , Jessica Yu , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, james.morse@arm.com, linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, May 11, 2020 at 08:51:15AM +0100, Will Deacon wrote: > On Sun, May 10, 2020 at 09:54:41AM +0200, Christoph Hellwig wrote: > > The second argument is the end "pointer", not the length. > > > > Signed-off-by: Christoph Hellwig > > --- > > arch/arm64/kernel/machine_kexec.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > > index 8e9c924423b4e..a0b144cfaea71 100644 > > --- a/arch/arm64/kernel/machine_kexec.c > > +++ b/arch/arm64/kernel/machine_kexec.c > > @@ -177,6 +177,7 @@ void machine_kexec(struct kimage *kimage) > > * the offline CPUs. Therefore, we must use the __* variant here. > > */ > > __flush_icache_range((uintptr_t)reboot_code_buffer, > > + (uintptr_t)reboot_code_buffer + > > arm64_relocate_new_kernel_size); > > Urgh, well spotted. It's annoyingly different from __flush_dcache_area(). > > But now I'm wondering what this code actually does... the loop condition > in invalidate_icache_by_line works with 64-bit arithmetic, so we could > spend a /very/ long time here afaict. I think it goes through the loop only once. The 'b.lo' saves us here. OTOH, there is no I-cache maintenance done. > It's also a bit annoying that we do a bunch of redundant D-cache > maintenance too. Should we use invalidate_icache_range() here instead? Since we have the __flush_dcache_area() above it for cleaning to PoC, we could use invalidate_icache_range() here. We probably didn't have this function at the time, it was added for KVM (commit 4fee94736603cd6). > (and why does that thing need to toggle uaccess)? invalidate_icache_range() doesn't need to, it works on the kernel linear map. __flush_icache_range() doesn't need to either, that's a side-effect of the fall-through implementation. Anyway, I think Christoph's patch needs to go in with a fixes tag: Fixes: d28f6df1305a ("arm64/kexec: Add core kexec support") Cc: # 4.8.x- and we'll change these functions/helpers going forward for arm64. Happy to pick this up via the arm64 for-next/fixes branch. -- Catalin