From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84317C54E8D for ; Mon, 11 May 2020 15:13:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D60B206D9 for ; Mon, 11 May 2020 15:13:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FjiroojC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D60B206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Z+RpUw3foq2DoulpysZqJ3WImdCphBXYhljKnr3/yI=; b=FjiroojCwXAih0WMc+kyED1JG vZoAbBWajG22x+cktZaJRwMKoGgsKMkPgf7/wmVClPYDl/SqcLGmIPQNM+jMCFBVGDaLeuVh4w1vD zj6erhSpQu5lnkR8ytz6UzxLfQuXwm7yQdUZ/3yxGHAKwy1iZcjoKc7FnpIGnO7vRNB1QLZ3ItXK2 LorFYdwUu0lOl/J2HMOqWE4L0cSOZwY/CHFo0EfY7D6OUsRAxK7XsC72+Sa5Lszq3kXcqO3pCv3B5 a4ppG8TmD7s/9PuLQaE0MKMz6DaUcTa0GLGChWPR1WY8PfIlASh+Sdf8+P0aBvhbCSPtskQMTSXzi AtIYs3iQQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYA7n-0001Y7-ON; Mon, 11 May 2020 15:13:47 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYA7V-0007jb-1H; Mon, 11 May 2020 15:13:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2865568BFE; Mon, 11 May 2020 17:11:21 +0200 (CEST) Date: Mon, 11 May 2020 17:11:20 +0200 From: Christoph Hellwig To: Geert Uytterhoeven Subject: Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k Message-ID: <20200511151120.GA28634@lst.de> References: <20200510075510.987823-1-hch@lst.de> <20200510075510.987823-32-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_081329_257225_56C6BA8C X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Roman Zippel , "open list:BROADCOM NVRAM DRIVER" , Linux MM , sparclinux , linux-riscv@lists.infradead.org, Christoph Hellwig , Linux-Arch , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , "open list:TENSILICA XTENSA PORT \(xtensa\)" , Arnd Bergmann , Jessica Yu , linux-um , linux-m68k , Openrisc , Linux ARM , Michal Simek , Linux Kernel Mailing List , alpha , Linux FS Devel , Andrew Morton , linuxppc-dev Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, May 11, 2020 at 09:40:39AM +0200, Geert Uytterhoeven wrote: > On Sun, May 10, 2020 at 9:57 AM Christoph Hellwig wrote: > > > > flush_icache_range generally operates on kernel addresses, but for some > > reason m68k needed a set_fs override. Move that into the m68k code > > insted of keeping it in the module loader. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven Btw, do you know what part of flush_icache_range relied on set_fs? Do any of the m68k maintainers have an idea how to handle that in a nicer way when we can split the implementations?