From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4991C54F4C for ; Fri, 4 Sep 2020 18:10:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5A2C25471 for ; Fri, 4 Sep 2020 18:06:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nd6FDN4C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5A2C25471 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LPtevSAdLH0rBm2j2NGklZiiTKyOgHwy349e2/5Gu90=; b=nd6FDN4CuLSqrAtheY/l1CYJY ncWafRnUwolAx4L3obepjJUrsHL2EzecFtdN0On0M7HJ4jyZjyl4dQwK1Eu6hozpGDkvCww/K9jhN gfu0zi1UUALu2EiGcy0N1XUSVVtaEWMPXNy6p3sRwoCz2dNLUgFGYqiPfMn90TbW5hx2AiuAWtvSg LQUW1DoUAXno9xgdypfKBDjgcXsBx7Fr1qaBlNimz+yuhTumS6cP/Kc8XsS0rN5lVs+Hm8nNOx/RR 9GJcXPm/g167kXINTRqpGqB2o9F1aie9AlPPN8qIQ9M/uBLXxe5NpkKzgTtcR1HwAB7juTAp18ceW a7ESmQ3Cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEG6c-0008Ss-Pi; Fri, 04 Sep 2020 18:06:34 +0000 Received: from [2002:c35c:fd02::1] (helo=ZenIV.linux.org.uk) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEG6Y-0008SE-EV for linux-riscv@lists.infradead.org; Fri, 04 Sep 2020 18:06:32 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEG6L-00ATnC-Uh; Fri, 04 Sep 2020 18:06:18 +0000 Date: Fri, 4 Sep 2020 19:06:17 +0100 From: Al Viro To: Christoph Hellwig Subject: Re: [PATCH 3/8] asm-generic: fix unaligned access hamdling in raw_copy_{from,to}_user Message-ID: <20200904180617.GQ1236603@ZenIV.linux.org.uk> References: <20200904165216.1799796-1-hch@lst.de> <20200904165216.1799796-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200904165216.1799796-4-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_140630_495334_DFB94AA0 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Sep 04, 2020 at 06:52:11PM +0200, Christoph Hellwig wrote: > Use get_unaligned and put_unaligned for the small constant size cases > in the generic uaccess routines. This ensures they can be used for > architectures that do not support unaligned loads and stores, while > being a no-op for those that do. Frankly, I would rather get rid of those constant-sized cases entirely; sure, we'd need to adjust asm-generic/uaccess.h defaults for __get_user(), but there that kind of stuff would make sense; in raw_copy_from_user() it really doesn't. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv