From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686DBC43464 for ; Thu, 17 Sep 2020 20:14:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8A2520707 for ; Thu, 17 Sep 2020 20:13:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FkJpfpR7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ghKM0GYx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8A2520707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T6ABPwsY9IEpJ7I0lv1YttuCVvSLwik2OIvjwJ8Zb7M=; b=FkJpfpR7LFu2GbCuvBw9sVFhr m2+g7br6DQ53NhXwf6cAKe+2NdCQotOvhbtZy151HC48Cm0+BhKIVRpxXvlWWDE4uW37VdnGGw9SI 5bNFP0zjOFFIbqFEozkv7WoOegS/+rbbGevYd8W1zUWX62xgMW1SAfVQatZ37t8P0/w/Ad9GuFjO/ BvWrZDVuuRyN8Zc7oktYw/vJXbzVKgwyjbwFJ5dYzRBnAvn25FGlLPGWoI2KRVZaJeLuts9rZg6gY eRU2piveAGw0SIqnT82zwXn1xPNBCBxU7EFPgrm47w241I+iy0PggQq5BjLM+Gr6DTlVr7H1m9Kj9 7fGNn3eyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ0Hr-0002gc-5l; Thu, 17 Sep 2020 20:13:47 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ0Hm-0002fK-9U; Thu, 17 Sep 2020 20:13:43 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E541EFED; Thu, 17 Sep 2020 22:13:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600373621; bh=Lgq9PKRDYhVRmNU7RasyOZL9cSKALVzKVkOgyrxq3OM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ghKM0GYxCHRhO2OzSWfqAhvO7iCRt7cu1MM1uolJIk+nsQMPRL7i+oqzAG17EDXFX hXLgKqL8giZLAXpZS4JYEwCm7oygNVuf1gJW1iEqCumOXugar6+RcBIw2vSYE1k5Ma eNzDgBcqBKHUcXSs2SWfCLHPqVWYAO4XJE6hsiWs= Date: Thu, 17 Sep 2020 23:13:11 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Subject: Re: [PATCH v2 02/13] dt-bindings: gpio: include common schema in GPIO controllers Message-ID: <20200917201311.GH3969@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-3-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917165301.23100-3-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_161342_598981_E1666895 X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amelie Delaunay , Geert Uytterhoeven , Matti Vaittinen , Linus Walleij , alsa-devel@alsa-project.org, Stefan Agner , Bjorn Andersson , Paul Cercueil , Masahiro Yamada , Chris Brandt , Srinivas Kandagatla , Manivannan Sadhasivam , linux-riscv@lists.infradead.org, Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Anson Huang , Lee Jones , Takashi Iwai , Magnus Damm , Bartosz Golaszewski , Chen-Yu Tsai , Andy Gross , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Andy Teng , Jacopo Mondi , Jaroslav Kysela , Sungbo Eo , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Cristian Ciocaltea , Charles Keepax , Maxime Coquelin , Ray Jui , Sascha Hauer , Sean Wang , Maxime Ripard , linux-gpio@vger.kernel.org, Richard Fitzgerald , Rob Herring , linux-mediatek@lists.infradead.org, Paul Walmsley , Matthias Brugger , Sricharan R , Mauro Carvalho Chehab , Hoan Tran , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Scott Branden , linux-unisoc@lists.infradead.org, - , Chris Packham , Liam Girdwood , Serge Semin , linux-kernel@vger.kernel.org, Paul Kocialkowski , Yash Shah , Kieran Bingham , Palmer Dabbelt , Mark Brown , Pengutronix Kernel Team , linux-media@vger.kernel.org, Shawn Guo , Andreas =?utf-8?Q?F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thank you for the patch. On Thu, Sep 17, 2020 at 06:52:50PM +0200, Krzysztof Kozlowski wrote: > Include the common GPIO schema in GPIO controllers to be sure all common > properties are properly validated. Same comment as for patch 09/13, shouldn't we delete redundant properties from all these schemas ? > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Fix gpio-mxs.yaml > 2. Add snps,dw-apb-gpio.yaml > --- > .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-mxs.yaml | 4 ++++ > Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-rda.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml | 1 + > Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 3 +++ > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 3 +++ > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 3 +++ > .../devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 3 +++ > 14 files changed, 41 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > index c213cb9ddb9f..1ac69b9c03f9 100644 > --- a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > @@ -13,6 +13,9 @@ description: | > This controller is the Chip Common A GPIO present on a number of Broadcom > switch ASICs with integrated SoCs. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: brcm,iproc-gpio-cca > diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > index de0b9b5f6a70..737756e081fb 100644 > --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml > @@ -9,6 +9,9 @@ title: Freescale i.MX/MXC GPIO controller > maintainers: > - Anson Huang > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > oneOf: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > index dfa1133f8c5e..bd0c4f329625 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-mxs.yaml > @@ -34,6 +34,10 @@ properties: > patternProperties: > "gpio@[0-9]+$": > type: object > + > + allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > index 338c5312a106..69b12041c893 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml > @@ -9,6 +9,9 @@ title: PCA9570 I2C GPO expander > maintainers: > - Sungbo Eo > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > index 6ece555f074f..d70c99f463c2 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-rda.yaml > @@ -9,6 +9,9 @@ title: RDA Micro GPIO controller > maintainers: > - Manivannan Sadhasivam > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: rda,8810pl-gpio > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > index 6ac5a78ad3da..82f3e4b407d1 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > @@ -17,6 +17,9 @@ description: | > Note: Each GPIO port should have an alias correctly numbered in "aliases" > node. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > index 4db3b8a3332c..e2b7d2d133a8 100644 > --- a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml > @@ -12,6 +12,7 @@ maintainers: > - Rob Herring > > allOf: > + - $ref: gpio-common.yaml# > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > index 32a566ec3558..2eee374e8396 100644 > --- a/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml > @@ -13,6 +13,9 @@ description: | > Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated > gpio controller to control 5 gpios on the chip. > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml b/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > index 8bdef812c87c..845689807678 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > +++ b/Documentation/devicetree/bindings/gpio/renesas,em-gio.yaml > @@ -9,6 +9,9 @@ title: Renesas EMMA Mobile General Purpose I/O Interface > maintainers: > - Magnus Damm > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: renesas,em-gio > diff --git a/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml b/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > index 5026662e4508..c116000d579f 100644 > --- a/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml > @@ -9,6 +9,9 @@ title: Renesas R-Car General-Purpose Input/Output Ports (GPIO) > maintainers: > - Geert Uytterhoeven > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > oneOf: > diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > index a0efd8dc2538..f2d93b40fc7e 100644 > --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml > @@ -10,6 +10,9 @@ maintainers: > - Yash Shah > - Paul Walmsley > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > items: > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index b391cc1b4590..459aafe5fd47 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -49,6 +49,9 @@ properties: > patternProperties: > "^gpio-(port|controller)@[0-9a-f]+$": > type: object > + allOf: > + - $ref: gpio-common.yaml# > + > properties: > compatible: > const: snps,dw-apb-gpio-port > diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > index c58ff9a94f45..94a911e9c313 100644 > --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml > @@ -9,6 +9,9 @@ title: UniPhier GPIO controller > maintainers: > - Masahiro Yamada > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > $nodename: > pattern: "^gpio@[0-9a-f]+$" > diff --git a/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml b/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > index a36aec27069c..0e4581241b3f 100644 > --- a/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml > @@ -23,6 +23,9 @@ description: | > - EN_VEE (power control) mapped to index 7 > - V_EN (power control) mapped to index 8 > > +allOf: > + - $ref: gpio-common.yaml# > + > properties: > $nodename: > pattern: "^gpio@[0-9a-f]+$" -- Regards, Laurent Pinchart _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv