From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: kernel test robot <lkp@intel.com>,
smueller@chronox.de, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-riscv@lists.infradead.org,
kernel-team@android.com
Subject: get_cycles from modular code in jitterentropy, was Re: [PATCH] clocksource: clint: Export clint_time_val for modules
Date: Fri, 2 Oct 2020 07:49:05 +0100 [thread overview]
Message-ID: <20201002064905.GA27115@infradead.org> (raw)
In-Reply-To: <20200930065617.934638-1-palmerdabbelt@google.com>
On Tue, Sep 29, 2020 at 11:56:18PM -0700, Palmer Dabbelt wrote:
> clint_time_val will soon be used by the RISC-V implementation of
> random_get_entropy(), which is a static inline function that may be used by
> modules (at least CRYPTO_JITTERENTROPY=m).
At very least this needs to be an EXPORT_SYMBOL_GPL. But I really don't
think modules have any business using get_cycles, so I'd much rather
fix CRYPTO_JITTERENTROPY to be required to be build in.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
> drivers/clocksource/timer-clint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c
> index d17367dee02c..6cfe2ab73eb0 100644
> --- a/drivers/clocksource/timer-clint.c
> +++ b/drivers/clocksource/timer-clint.c
> @@ -38,6 +38,7 @@ static unsigned int clint_timer_irq;
>
> #ifdef CONFIG_RISCV_M_MODE
> u64 __iomem *clint_time_val;
> +EXPORT_SYMBOL(clint_time_val);
> #endif
>
> static void clint_send_ipi(const struct cpumask *target)
> --
> 2.28.0.709.gb0816b6eb0-goog
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
---end quoted text---
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-10-02 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:56 [PATCH] clocksource: clint: Export clint_time_val for modules Palmer Dabbelt
2020-10-02 6:49 ` Christoph Hellwig [this message]
2020-10-02 6:55 ` get_cycles from modular code in jitterentropy, was " Stephan Mueller
2020-10-04 18:48 ` [PATCH] crypto: jitterentropy - bind statically into kernel Stephan Müller
2020-10-04 21:16 ` Ard Biesheuvel
2020-10-04 22:05 ` Palmer Dabbelt
2020-10-05 6:19 ` Christoph Hellwig
2020-10-05 6:24 ` Ard Biesheuvel
2020-10-05 6:40 ` Stephan Mueller
2020-10-05 6:44 ` Christoph Hellwig
2020-10-05 6:44 ` Ard Biesheuvel
2020-10-05 6:56 ` Christoph Hellwig
2020-10-05 7:45 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002064905.GA27115@infradead.org \
--to=hch@infradead.org \
--cc=kernel-team@android.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmerdabbelt@google.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox