Re: [PATCH 24/32] dt-bindings: Document kendryte,k210-fpioa bindings

Damien Le Moal
2020-11-19T11:22:44Z

On 2020/11/19 19:58, Geert Uytterhoeven wrote:
> Hi Damien, Sean,
>
> On Mon, Nov 9, 2020 at 4:46 PM Sean Anderson <seanga2@gmail.com> wrote:
>> On 11/9/20 10:36 AM, Rob Herring wrote:
>>> On Sat, Nov 07, 2020 at 05:14:12PM +0900, Damien Le Moal wrote:
>>>> Document the device tree bindings for the Kendryte K210 SoC Fully
>>>> Programmable IO Array (FPIOA) pinctrl driver in
>>>> Documentation/devicetree/bindings/pinctrl/kendryte,k210-fpioa.yaml
>>>>
>>>> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
>
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/kendryte,k210-fpioa.yaml
>
>>>> + kendryte,power-offset:
>>>> + minItems: 1
>>>> + maxItems: 1
>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>> + description: |
>>>> + Offset of the power domain control register of the system controller.
>>>
>>> Sounds like you should be using power-domains binding.
>>
>> This is for pin power domains. E.g. pins 0-5 can be set to 1V8 or 3V3 logic levels.
>
> Which brings to my attention the power-source property is not
> documented below...
>
>>>> + The value should be the macro K210_SYSCTL_POWER_SEL defined in
>>>> + dt-bindings/mfd/k210-sysctl.h.
>>>> +
>>>> +patternProperties:
>>>> + '^.*$':
>>>> + if:
>>>> + type: object
>>>> + then:
>
> As the driver supports e.g. bias and drive-strength, these should be
> documented here, too.

Thanks for the review. I fixed everything today and ran everything through "make
dt_binding_check". Will send a V2 series tomorrow after some more fixes and tests.

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>

--
Damien Le Moal
Western Digital Research