From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: devicetree@vger.kernel.org, aou@eecs.berkeley.edu,
lewis.hanly@microchip.com, david.abdurachmanov@gmail.com,
daire.mcnamara@microchip.com, jassisinghbrar@gmail.com,
atish.patra@wdc.com, anup.patel@wdc.com, palmer@dabbelt.com,
paul.walmsley@sifive.com, cyril.jean@microchip.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/6] dt-bindings: add bindings for polarfire soc mailbox
Date: Fri, 20 Nov 2020 14:52:50 -0600 [thread overview]
Message-ID: <20201120205250.GB1716438@robh.at.kernel.org> (raw)
In-Reply-To: <20201119170432.18447-1-conor.dooley@microchip.com>
On Thu, Nov 19, 2020 at 05:04:32PM +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the MSS system controller mailbox on
> the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../mailbox/microchip,mpfs-mailbox.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml
> new file mode 100644
> index 000000000000..5d6ccaa13dc2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/mailbox/microchip,mpfs-mailbox.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Microchip MPFS mss mailbox controller
> +
> +maintainers:
> + - Conor Dooley <conor.dooley@microchip.com>
> +
> +properties:
> + compatible:
> + const: microchip,polarfire-soc-mailbox # PolarFire
Comment is redundant.
> +
> + reg:
> + items:
> + - description: mailbox data registers
> + - description: mailbox int registers
> + maxItems: 2
maxItems is implied by size of 'items'.
> +
> + interrupts:
> + maxItems: 1
> +
> + "#mbox-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-parent
> + - interrupts
> + - "#mbox-cells"
> +
> +unevaluatedProperties: false
> +additionalProperties: false
Only need one and in this case additionalProperties.
> +
> +examples:
> + - |
> + mailbox@37020000 {
> + compatible = "microchip,polarfire-soc-mailbox";
> + reg = <0x0 0x37020000 0x0 0x1000>, <0x0 0x2000318c 0x0 0x40>;
> + interrupt-parent = <&L1>;
> + interrupts = <96>;
> + #mbox-cells = <1>;
> + };
> --
> 2.17.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-11-20 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:04 [PATCH 3/6] dt-bindings: add bindings for polarfire soc mailbox conor.dooley
2020-11-20 0:14 ` Damien Le Moal
2020-11-30 13:17 ` Conor.Dooley
2020-11-20 20:49 ` Rob Herring
2020-11-20 20:52 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120205250.GB1716438@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox