From: Eric Lin <tesheng@andestech.com>
To: Pekka Enberg <penberg@gmail.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
LKML <linux-kernel@vger.kernel.org>, Peter Xu <peterx@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v2 0/2] Let illegal access to user-space memory die
Date: Thu, 3 Dec 2020 16:16:55 +0800 [thread overview]
Message-ID: <20201203081655.GB25276@atcfdc88> (raw)
In-Reply-To: <CAOJsxLHo6-6w9M3H1UP1hPX1bnxZ06tqbnc9cwR5_sLQBgA7HA@mail.gmail.com>
On Thu, Dec 03, 2020 at 03:29:57PM +0800, Pekka Enberg wrote:
Hi Pekka,
> Hi Eric,
>
> On Thu, Dec 3, 2020 at 8:51 AM Eric Lin <tesheng@andestech.com> wrote:
> >
> > Accesses to user-space memory without calling uaccess routine
> > leads to hanging in page fault handler. Like arm64, we let it
> > die earlier in page fault handler.
> >
> > Changes in v2:
> > -Add a die_kernel_fault() helper
> > -Split one long line code into two
>
> Please also make no_context() use the new helper. Other than that:
>
OK, I'll make no_context() use the new helper in v3.
Thanks for your review.
> Reviewed-by: Pekka Enberg <penberg@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-12-03 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 6:48 [PATCH v2 0/2] Let illegal access to user-space memory die Eric Lin
2020-12-03 6:48 ` [PATCH v2 1/2] riscv/mm: Introduce a die_kernel_fault() helper function Eric Lin
2020-12-03 6:48 ` [PATCH v2 2/2] riscv/mm: Prevent kernel module to access user memory without uaccess routines Eric Lin
2020-12-03 7:29 ` [PATCH v2 0/2] Let illegal access to user-space memory die Pekka Enberg
2020-12-03 8:16 ` Eric Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203081655.GB25276@atcfdc88 \
--to=tesheng@andestech.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=penberg@gmail.com \
--cc=peterx@redhat.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox