From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: lkp@intel.com, daniel.lezcano@linaro.org,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-riscv@lists.infradead.org, kernel-team@android.com,
tglx@linutronix.de
Subject: Re: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()
Date: Thu, 24 Dec 2020 06:39:38 +0000 [thread overview]
Message-ID: <20201224063938.GA2758@infradead.org> (raw)
In-Reply-To: <mhng-b2cf0325-66e1-4e3c-bfbb-b393963fbb3f@palmerdabbelt-glaptop>
On Wed, Dec 23, 2020 at 06:59:34PM -0800, Palmer Dabbelt wrote:
> Aren't we OK with lines longer than 80 characters now? Or was that some other
> project? checkpatch doesn't complain, which I guess is why I didn't notice, so
> hopefully that means I'm not crazy (though I guess the commit message and title
> don't provide the best argument there... ;)).
They are allowed as an exception, not the norm. Take a look at the
coding style document. And checkpath has for a while not been doing the
right thing unfortunately.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-12-24 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:32 [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi() Palmer Dabbelt
2020-12-22 9:34 ` David Laight
2020-12-23 8:23 ` Christoph Hellwig
2020-12-24 2:59 ` Palmer Dabbelt
2020-12-24 6:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224063938.GA2758@infradead.org \
--to=hch@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox