Re: [PATCH v4] RISC-V: enable XIP

kernel test robot
2021-03-07T09:42:23Z

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Hi Vitaly,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc2 next-20210305]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Vitaly-Wool/RISC-V-enable-XIP/20210307-103904
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 280d542f6ffac0e6d65dc267f92191d509b13b64
config: riscv-defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c9cb15092dcf53140fba57780677a9dcaef70612
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vitaly-Wool/RISC-V-enable-XIP/20210307-103904
git checkout c9cb15092dcf53140fba57780677a9dcaef70612
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/riscv/kernel/cpu_ops_sbi.c: In function 'get_secondary_start_phys':
>> arch/riscv/kernel/cpu_ops_sbi.c:59:3: error: implicit declaration of function 'XIP_PHYS_ADDR' [-Werror=implicit-function-declaration]
59 | XIP_PHYS_ADDR(secondary_start_sbi) :
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/XIP_PHYS_ADDR +59 arch/riscv/kernel/cpu_ops_sbi.c

55
56 static inline unsigned long get_secondary_start_phys(void)
57 {
58 return IS_ENABLED(CONFIG_XIP_KERNEL) ?
> 59 XIP_PHYS_ADDR(secondary_start_sbi) :
60 __pa_symbol(secondary_start_sbi);
61 }
62

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 21443 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]