Re: [PATCH v2 1/3] riscv: Move kernel mapping outside of linear mapping

From: kernel test robot <lkp@intel.com>
To: Alexandre Ghiti <alex@ghiti.fr>, Jonathan Corbet <corbet@lwn.net>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/3] riscv: Move kernel mapping outside of linear mapping
Date: Sat, 13 Mar 2021 19:15:02 +0800	[thread overview]
Message-ID: <202103131935.epyMAI3S-lkp@intel.com> (raw)
In-Reply-To: <20210313092509.4918-2-alex@ghiti.fr>

[-- Attachment #1: Type: text/plain, Size: 3058 bytes --]

Hi Alexandre,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on lwn/docs-next]
[also build test ERROR on linus/master v5.12-rc2 next-20210312]
[cannot apply to soc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexandre-Ghiti/Move-kernel-mapping-outside-the-linear-mapping/20210313-173049
base:   git://git.lwn.net/linux-2.6 docs-next
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/78f684d0ab9dfe75ab40951ce9edd835b6658209
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexandre-Ghiti/Move-kernel-mapping-outside-the-linear-mapping/20210313-173049
        git checkout 78f684d0ab9dfe75ab40951ce9edd835b6658209
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/riscv/kernel/setup.c: In function 'setup_arch':
>> arch/riscv/kernel/setup.c:269:2: error: implicit declaration of function 'protect_kernel_linear_mapping_text_rodata' [-Werror=implicit-function-declaration]
     269 |  protect_kernel_linear_mapping_text_rodata();
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/protect_kernel_linear_mapping_text_rodata +269 arch/riscv/kernel/setup.c

   235	
   236	void __init setup_arch(char **cmdline_p)
   237	{
   238		parse_dtb();
   239		init_mm.start_code = (unsigned long) _stext;
   240		init_mm.end_code   = (unsigned long) _etext;
   241		init_mm.end_data   = (unsigned long) _edata;
   242		init_mm.brk        = (unsigned long) _end;
   243	
   244		*cmdline_p = boot_command_line;
   245	
   246		early_ioremap_setup();
   247		jump_label_init();
   248		parse_early_param();
   249	
   250		efi_init();
   251		setup_bootmem();
   252		paging_init();
   253		init_resources();
   254	#if IS_ENABLED(CONFIG_BUILTIN_DTB)
   255		unflatten_and_copy_device_tree();
   256	#else
   257		if (early_init_dt_verify(__va(dtb_early_pa)))
   258			unflatten_device_tree();
   259		else
   260			pr_err("No DTB found in kernel mappings\n");
   261	#endif
   262		misc_mem_init();
   263	
   264		sbi_init();
   265	
   266		if (IS_ENABLED(CONFIG_STRICT_KERNEL_RWX))
   267			protect_kernel_text_data();
   268	
 > 269		protect_kernel_linear_mapping_text_rodata();
   270	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8404 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv