From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A44C433B4 for ; Mon, 17 May 2021 06:23:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20F396121F for ; Mon, 17 May 2021 06:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20F396121F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y4JcfoLSoFVS1OD/Hk+b6pL+RjXWbqPBwgeTtdIM3pM=; b=kvgaYdIr1oM/fQFcwgx5NVyqn 4hfP22b/CjzzIqf9HiunbgHcX0VhzlvMgiuZLYCTH2bCkN2HDsiwbSfXXD7Zg8/tkqRkJlkIsUE9Z Qta5s9PsrmbjPSpEI+WknMnoO6swpcz4ly3ZOHq668B4l+u4kUkm3BLkKVIjkjhbE+1yuTLJs3I2r 3WTxgsU1p7jjorwIB+Bpk54pR+HXXUhpyXS6K7mDF9nyM2jZ6IfYRU0UToYqBYsgd/lCyXQKVAJCp McO+jj9/DpxUeulXJGAnZUKDXmoS/tt/SNO6Tr+EiWKcC9Z65LoZRNij49WXmY9zATL4+9PjDS2kP aeiSG4tpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liWf0-00DrtS-2Y; Mon, 17 May 2021 06:23:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liWc4-00Dr5P-F4; Mon, 17 May 2021 06:20:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L3HgWD1ZWatejcOTZ8qpzoMfp2kYHt1Of2v8raX/g74=; b=wtw2lDqUaJp/Hx4yDfjWQfucrO 2ZVQbDtWpUSut6dYkvCYyK/Dn4ZoREBpU5/PxAfM9cL4g1Nsnvsf4lXpptkhbjnE95hEDigyW0ON0 1q9esjeSMiettx7n711+65CQRkd94ZAli2hahdvVouKUAntJ9Ia3FMOICkb/ULU8gvLrjlXst4WYo 18FCTflZEZ8y8zrUC/cAr/bdlQO2w3yFbTRf+Se4PpSCUouktJaNTH1X3WgrXb2M+hjZO/+0LVPEE G4sj4ldkflRsa5vXh1d6caC2F6vL1rzK6qcfV0YFYv3FsxnRLIp28WlTPAEymMsiuISEIY825jQJY 9r+zYHQw==; Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liWc1-00DVXF-UV; Mon, 17 May 2021 06:20:23 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 465B36736F; Mon, 17 May 2021 08:20:18 +0200 (CEST) Date: Mon, 17 May 2021 08:20:18 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Al Viro , Vineet Gupta , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jeff Dike , Richard Weinberger , Anton Ivanov , Sid Manning , Andrew Morton , Mike Rapoport , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-riscv@lists.infradead.org, linux-um@lists.infradead.org Subject: Re: [PATCH 5/6] [v2] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user Message-ID: <20210517062018.GC23581@lst.de> References: <20210515101803.924427-1-arnd@kernel.org> <20210515101803.924427-6-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210515101803.924427-6-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210516_232022_152065_7CB06EC6 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, May 15, 2021 at 12:18:02PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Consolidate the asm-generic implementation with the library version > that is used everywhere else. > > These are the three versions for NOMMU kernels, I don't get the three versions part? > + select GENERIC_STRNCPY_FROM_USER > + select GENERIC_STRNLEN_USER Given that most architetures select the generic version I wonder if it might be worth to add another patch to invert the logic so that architectures with their own implementation need to sekect a symbol. > +extern long strncpy_from_user(char *dst, const char __user *src, long count); > +extern long strnlen_user(const char __user *src, long n); No need for the extern here. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv