From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 563FBC433EF for ; Thu, 31 Mar 2022 12:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j4i6O787lGUCg05gFPmvbvr6zFHiEgPoNsWWgrgFIPg=; b=QSPxbpGzSW9qQw PpLXYdO5o1YhouKVhXhF96QIqA+v4UQpJOy0ywKyY0HsS7fqBzxCmQQwXHMIpCBMG4qVKrIjMjII8 VWQQd5gAhj+e/XsIeZDMrHpvsFE4iOkQhEskII8m7jhXyuVbedZYpRsa4CGOMiBE93r22/rTXk2AM 2SHGWJPW4mnDB5+3xmHoUEqnQRwR4Q58ki7GM3rHDNYTMqInGFQrN1XBjnzErk8wsI2ZTT/5vX9+R Ni0sU1woeM/Fm41DlU7zqOO5quj736/jWFU5/4DUUgSxBiKyHOTuDisJVhoUlr9ac+vUdqLklrYTe An08qj6BKdhUb/AwejJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtvu-002EeA-PE; Thu, 31 Mar 2022 12:29:46 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtvs-002EdD-Ja for linux-riscv@lists.infradead.org; Thu, 31 Mar 2022 12:29:45 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 53F8668AFE; Thu, 31 Mar 2022 14:29:39 +0200 (CEST) Date: Thu, 31 Mar 2022 14:29:38 +0200 From: Christoph Hellwig To: Heiko Stuebner Cc: palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wefu@redhat.com, liush@allwinnertech.com, guoren@kernel.org, atishp@atishpatra.org, anup@brainfault.org, drew@beagleboard.org, hch@lst.de, arnd@arndb.de, wens@csie.org, maxime@cerno.tech, gfavor@ventanamicro.com, andrea.mondelli@huawei.com, behrensj@mit.edu, xinhaoqu@huawei.com, mick@ics.forth.gr, allen.baum@esperantotech.com, jscheid@ventanamicro.com, rtrauben@gmail.com, samuel@sholland.org, cmuellner@linux.com, philipp.tomsich@vrull.eu, Wei Wu , Daniel Lustig , Bill Huffman Subject: Re: [PATCH v8 11/14] riscv: add RISC-V Svpbmt extension support Message-ID: <20220331122938.GB26108@lst.de> References: <20220324000710.575331-1-heiko@sntech.de> <20220324000710.575331-12-heiko@sntech.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220324000710.575331-12-heiko@sntech.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_052944_827669_8EEF7340 X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Mar 24, 2022 at 01:07:07AM +0100, Heiko Stuebner wrote: > +asm(ALTERNATIVE("li %0, 0\t\nnop", "li %0, %1\t\nslli %0,%0,%2", 0, \ > + CPUFEATURE_SVPBMT, CONFIG_64BIT) \ > + : "=r"(_val) : "I"(prot##_SVPBMT >> ALT_SVPBMT_SHIFT), "I"(ALT_SVPBMT_SHIFT)) This would be much more readable as; asm(ALTERNATIVE("li %0, 0\t\nnop", "li %0, %1\t\nslli %0,%0,%2", 0, \ CPUFEATURE_SVPBMT, CONFIG_64BIT) \ : "=r"(_val) \ : "I"(prot##_SVPBMT >> ALT_SVPBMT_SHIFT), \ "I"(ALT_SVPBMT_SHIFT)) Otherwise this looks good to me: Reviewed-by: Christoph Hellwig _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv