Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: wafgo01@gmail.com
To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Wadim Mueller <wafgo01@gmail.com>
Subject: [PATCH] Makefile: riscv: Remove duplicated -O binary objcopy flags
Date: Mon,  4 Apr 2022 15:08:35 +0200	[thread overview]
Message-ID: <20220404130835.108828-1-wafgo01@gmail.com> (raw)

From: Wadim Mueller <wafgo01@gmail.com>

In arch/riscv/Makefile the OBJCOPYFLAGS are already set to -O binary
so the duplicated flags for Image and xipImage generation can be
removed from arch/riscv/boot/Makefile.

The fact that the flags are indeed duplicated can be checked in
.Image.cmd which specifies -O binary twice

Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
---
 arch/riscv/boot/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
index becd0621071c..c000a1fc8c56 100644
--- a/arch/riscv/boot/Makefile
+++ b/arch/riscv/boot/Makefile
@@ -16,8 +16,8 @@
 
 KCOV_INSTRUMENT := n
 
-OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
-OBJCOPYFLAGS_xipImage :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
+OBJCOPYFLAGS_Image :=-R .note -R .note.gnu.build-id -R .comment -S
+OBJCOPYFLAGS_xipImage :=-R .note -R .note.gnu.build-id -R .comment -S
 
 targets := Image Image.* loader loader.o loader.lds loader.bin
 targets := Image Image.* loader loader.o loader.lds loader.bin xipImage
-- 
2.29.3


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

                 reply	other threads:[~2022-04-04 13:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220404130835.108828-1-wafgo01@gmail.com \
    --to=wafgo01@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox