From: Steven Rostedt <rostedt@goodmis.org>
To: Li kunyu <kunyu@nfschina.com>
Cc: mingo@redhat.com, linux@armlinux.org.uk,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH] kernel: Ftrace seems to have functions to improve performance through optimization through optimization
Date: Tue, 17 May 2022 10:13:51 -0400 [thread overview]
Message-ID: <20220517101351.273b385f@gandalf.local.home> (raw)
In-Reply-To: <20220513021314.59480-1-kunyu@nfschina.com>
On Fri, 13 May 2022 10:13:14 +0800
Li kunyu <kunyu@nfschina.com> wrote:
> Subject: [PATCH] kernel: Ftrace seems to have functions to improve performance through optimization through optimization
Did you forget to add a subject line. The above looks to be the beginning
of the paragraph below.
> Date: Fri, 13 May 2022 10:13:14 +0800
> Message-Id: <20220513021314.59480-1-kunyu@nfschina.com>
>
> such as ftrace_ARCH_code_*, return 0, so the FTRACE_* check is not required
And even combined, the above makes no sense.
This patch is not an optimization patch. If it were, the optimization
provided is so small, it's not worth adding it.
Just state that it's a clean up (I already told you this). Here, I'll do
the work for you (but I expect a proper patch):
Subject: [PATCH v2] ftrace: Remove return value of ftrace_arch_modify_*()
All instances of the function ftrace_arch_modify_prepare() and
ftrace_arch_modify_post_process() return zero. There's no point in
checking their return value. Just have them be void functions.
There, that's what I would like to see.
-- Steve
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-05-17 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 6:30 [PATCH] kernel: Ftrace seems to have functions to improve performance through optimization Li kunyu
2022-05-12 14:12 ` Steven Rostedt
2022-05-12 14:45 ` Li kunyu
2022-05-12 15:07 ` Steven Rostedt
2022-05-12 15:19 ` Li kunyu
2022-05-13 2:13 ` [PATCH] kernel: Ftrace seems to have functions to improve performance through optimization " Li kunyu
2022-05-17 14:13 ` Steven Rostedt [this message]
2022-05-18 2:36 ` [PATCH v2] ftrace: Remove return value of ftrace_arch_modify_*() Li kunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517101351.273b385f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=agordeev@linux.ibm.com \
--cc=aou@eecs.berkeley.edu \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=kunyu@nfschina.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liqiong@nfschina.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox