From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Cc: <conor.dooley@microchip.com>, <daire.mcnamara@microchip.com>,
<broonie@kernel.org>
Subject: [PATCH -next v2 1/3] spi: microchip-core: fix UAF in mchp_corespi_remove()
Date: Wed, 13 Jul 2022 10:56:55 +0800 [thread overview]
Message-ID: <20220713025657.3524506-2-yangyingliang@huawei.com> (raw)
In-Reply-To: <20220713025657.3524506-1-yangyingliang@huawei.com>
When using devm_spi_register_master(), the unregister function will
be called in devres_release_all() which is called after ->remove(),
so remove spi_unregister_master() andspi_master_put().
Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/spi/spi-microchip-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
index b3083075cd36..c26767343176 100644
--- a/drivers/spi/spi-microchip-core.c
+++ b/drivers/spi/spi-microchip-core.c
@@ -595,8 +595,6 @@ static int mchp_corespi_remove(struct platform_device *pdev)
struct mchp_corespi *spi = spi_master_get_devdata(master);
mchp_corespi_disable_ints(spi);
- spi_unregister_master(master);
- spi_master_put(master);
clk_disable_unprepare(spi->clk);
mchp_corespi_disable(spi);
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-13 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 2:56 [PATCH -next v2 0/3] spi: microchip-core: fix and cleanups Yang Yingliang
2022-07-13 2:56 ` Yang Yingliang [this message]
2022-07-13 2:56 ` [PATCH -next v2 2/3] spi: microchip-core: switch to use devm_spi_alloc_master() Yang Yingliang
2022-07-13 2:56 ` [PATCH -next v2 3/3] spi: microchip-core: switch to use dev_err_probe() Yang Yingliang
2022-07-13 7:03 ` [PATCH -next v2 0/3] spi: microchip-core: fix and cleanups Conor.Dooley
2022-07-13 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713025657.3524506-2-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox