From: Bjorn Helgaas <helgaas@kernel.org>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Greentime Hu" <greentime.hu@sifive.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] PCI: fu740: do not use clock name when requesting clock
Date: Fri, 23 Sep 2022 16:14:39 -0500 [thread overview]
Message-ID: <20220923211439.GA1418979@bhelgaas> (raw)
In-Reply-To: <20220907054020.745672-1-uwu@icenowy.me>
On Wed, Sep 07, 2022 at 01:40:20PM +0800, Icenowy Zheng wrote:
> The DT binding of FU740 PCIe does not enforce a clock-names property,
> and there exist some device tree that has a clock name that does not
> stick to the one used by Linux DT (e.g. the one shipped with current
> U-Boot mainline).
>
> Drop the name in the clock request, instead just pass NULL (because
> this device should have only a single clock).
If you rework this for any reason, please capitalize the subject line
to match the convention:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/pci/controller/dwc/pcie-fu740.c
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---
> drivers/pci/controller/dwc/pcie-fu740.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
> index 0c90583c078b..edb218a37a4f 100644
> --- a/drivers/pci/controller/dwc/pcie-fu740.c
> +++ b/drivers/pci/controller/dwc/pcie-fu740.c
> @@ -315,7 +315,7 @@ static int fu740_pcie_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");
>
> /* Fetch clocks */
> - afp->pcie_aux = devm_clk_get(dev, "pcie_aux");
> + afp->pcie_aux = devm_clk_get(dev, NULL);
> if (IS_ERR(afp->pcie_aux))
> return dev_err_probe(dev, PTR_ERR(afp->pcie_aux),
> "pcie_aux clock source missing or invalid\n");
> --
> 2.37.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-23 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 5:40 [PATCH] PCI: fu740: do not use clock name when requesting clock Icenowy Zheng
2022-09-08 18:14 ` Conor.Dooley
2022-09-12 1:38 ` Icenowy Zheng
2022-09-12 10:13 ` Conor.Dooley
2022-09-13 6:25 ` Icenowy Zheng
2022-09-23 21:14 ` Bjorn Helgaas [this message]
2022-09-23 21:25 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923211439.GA1418979@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=greentime.hu@sifive.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox