From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Yipeng Zou <zouyipeng@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<rostedt@goodmis.org>, <mingo@redhat.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <zanussi@kernel.org>,
<liaochang1@huawei.com>, <chris.zjh@huawei.com>
Subject: Re: [PATCH 1/2] tracing: kprobe: fix kprobe event gen test module on exit
Date: Fri, 23 Sep 2022 23:03:40 +0900 [thread overview]
Message-ID: <20220923230340.cc2b2c714a4f45624f9f23bf@kernel.org> (raw)
In-Reply-To: <20220919125629.238242-2-zouyipeng@huawei.com>
On Mon, 19 Sep 2022 20:56:28 +0800
Yipeng Zou <zouyipeng@huawei.com> wrote:
> Correct gen_kretprobe_test clr event para on module exit.
> This will make it can't to delete.
Looks good to me. (actually, both tests will use the same root
trace_array, so the test itself will not fail, but this should
be fixed.)
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
>
> Fixes: 64836248dda2 ("tracing: Add kprobe event command generation test module")
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> ---
> kernel/trace/kprobe_event_gen_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/kprobe_event_gen_test.c b/kernel/trace/kprobe_event_gen_test.c
> index 18b0f1cbb947..e023154be0f8 100644
> --- a/kernel/trace/kprobe_event_gen_test.c
> +++ b/kernel/trace/kprobe_event_gen_test.c
> @@ -206,7 +206,7 @@ static void __exit kprobe_event_gen_test_exit(void)
> WARN_ON(kprobe_event_delete("gen_kprobe_test"));
>
> /* Disable the event or you can't remove it */
> - WARN_ON(trace_array_set_clr_event(gen_kprobe_test->tr,
> + WARN_ON(trace_array_set_clr_event(gen_kretprobe_test->tr,
> "kprobes",
> "gen_kretprobe_test", false));
>
> --
> 2.17.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-23 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 12:56 [PATCH 0/2] fix kprobe event gen test module Yipeng Zou
2022-09-19 12:56 ` [PATCH 1/2] tracing: kprobe: fix kprobe event gen test module on exit Yipeng Zou
2022-09-23 14:03 ` Masami Hiramatsu [this message]
2022-09-19 12:56 ` [PATCH 2/2] tracing: kprobe: make gen test module work in arm and riscv Yipeng Zou
2022-09-23 14:05 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923230340.cc2b2c714a4f45624f9f23bf@kernel.org \
--to=mhiramat@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=chris.zjh@huawei.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox