From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F821C433FE for ; Sun, 2 Oct 2022 09:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IfM+RNcXjZQ72aBVIyOQ37fJgsV7b7IMhiAlG54DmCI=; b=Cf7m2eBB1jOoyF 3yBCK2uv9Gm0MDCoRmv1F/WDiB7G842cWpD9+rb0CRz70BTuaj3OB1XCP6sLO/jWcED6LzUb8XsMD E97elTsyU2tzi+MGJFMlMg0puIlH8tyZlvnF2BBqOPXPck1mNOXZua2A9JjG+AzdQ2nT1q+7Y2p3F //EFIR+XvbdUZZNnuhxbXCIiNvwg2mKSdwHv9nDn0L7OPM9vguP2dlRRwUxA1Y7y2Ije+7iyBsSsu dYemLUHHSypUUhfBOBVuARKHKE1DzHgEcpqLQMgT/2b8zGMrvVI4rYZv1oVR6Kw7e4oOWvSEvS7JA SYr6aUcCb8vhl7AU92Hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeuzm-000RKU-F6; Sun, 02 Oct 2022 09:10:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeuzj-000RJ4-9P for linux-riscv@lists.infradead.org; Sun, 02 Oct 2022 09:10:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 147DA60DC6; Sun, 2 Oct 2022 09:10:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52115C433C1; Sun, 2 Oct 2022 09:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664701840; bh=5X22PodWEVJnuCJzCc8iLgd8TlBW1oUTJJeQujPfeRo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UYvU0V3Q2eYpxyImGQ2SpFuFlI+JTCaFmr+uAxnb7k3oAeiGRzgr8AIYvYJz3uQmc igZ6QKh+xah/9vtByKiw7neSp5raRvPv5sIgP2EEocNJ4cExvPaHgyEfZCUWvBuSwR TS1yHqcWhlwR89zb5loGpYsLYlWdKx2fCu+TnM7NILkKhV0e6/gfM/NNsZxIZ3c4yQ zW/gQC8sBbqbM7//HT5SxAuyliqVL3eA03Q0irp0V9QgVsHkdeZXzrqgzrBAq0Plcl nH6QP5h909wBjRPG5yY0hlIhTLyQgW8a7kfkmKBM8w6iWFIlH597WTKzvDNj8loePS AQTVA5pKmFupA== Date: Sun, 2 Oct 2022 18:10:35 +0900 From: Masami Hiramatsu (Google) To: Binglei Wang Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8] rethook: add riscv rethook implementation Message-Id: <20221002181035.490ad0155d741e39faa29716@kernel.org> In-Reply-To: <20220930081357.651914-1-l3b2w1@gmail.com> References: <20220930081357.651914-1-l3b2w1@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221002_021043_460116_08C71277 X-CRM114-Status: GOOD ( 27.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, 30 Sep 2022 16:13:57 +0800 Binglei Wang wrote: > From: Binglei Wang > > Implement the kretprobes on riscv arch by using rethook machenism > which abstracts general kretprobe info into a struct rethook_node > to be embedded in the struct kretprobe_instance. > > Signed-off-by: Binglei Wang This looks good to me. Acked-by: Masami Hiramatsu (Google) Thank you, > --- > > Notes: > v8: Add the omitted rethook.h > v7: Add the changelog. > v6: Remove the kretprobes trampoline. > v5: Trt to fix robot compiling error and warnings. > v4: Add patch version number. > v3: Trt to fix robot compiling error and warnings. > v2: Add comit log to explain reasons behind changes. > Use my personal email instead of work email > to avoid the attachments of company informaton. > Make the kprobes_trampoline.S code to be shared. > v1: Add riscv rethook implementation. > > arch/riscv/Kconfig | 1 + > arch/riscv/include/asm/kprobes.h | 2 -- > arch/riscv/kernel/probes/Makefile | 2 +- > arch/riscv/kernel/probes/kprobes.c | 13 --------- > arch/riscv/kernel/probes/rethook.c | 27 +++++++++++++++++++ > arch/riscv/kernel/probes/rethook.h | 8 ++++++ > ...obes_trampoline.S => rethook_trampoline.S} | 6 ++--- > 7 files changed, 40 insertions(+), 19 deletions(-) > create mode 100644 arch/riscv/kernel/probes/rethook.c > create mode 100644 arch/riscv/kernel/probes/rethook.h > rename arch/riscv/kernel/probes/{kprobes_trampoline.S => rethook_trampoline.S} (94%) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 59d18881f..bfb66cdc5 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -97,6 +97,7 @@ config RISCV > select HAVE_KPROBES if !XIP_KERNEL > select HAVE_KPROBES_ON_FTRACE if !XIP_KERNEL > select HAVE_KRETPROBES if !XIP_KERNEL > + select HAVE_RETHOOK if !XIP_KERNEL > select HAVE_MOVE_PMD > select HAVE_MOVE_PUD > select HAVE_PCI > diff --git a/arch/riscv/include/asm/kprobes.h b/arch/riscv/include/asm/kprobes.h > index 217ef89f2..e7882ccb0 100644 > --- a/arch/riscv/include/asm/kprobes.h > +++ b/arch/riscv/include/asm/kprobes.h > @@ -40,8 +40,6 @@ void arch_remove_kprobe(struct kprobe *p); > int kprobe_fault_handler(struct pt_regs *regs, unsigned int trapnr); > bool kprobe_breakpoint_handler(struct pt_regs *regs); > bool kprobe_single_step_handler(struct pt_regs *regs); > -void __kretprobe_trampoline(void); > -void __kprobes *trampoline_probe_handler(struct pt_regs *regs); > > #endif /* CONFIG_KPROBES */ > #endif /* _ASM_RISCV_KPROBES_H */ > diff --git a/arch/riscv/kernel/probes/Makefile b/arch/riscv/kernel/probes/Makefile > index 7f0840dcc..c40139e9c 100644 > --- a/arch/riscv/kernel/probes/Makefile > +++ b/arch/riscv/kernel/probes/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_KPROBES) += kprobes.o decode-insn.o simulate-insn.o > -obj-$(CONFIG_KPROBES) += kprobes_trampoline.o > +obj-$(CONFIG_RETHOOK) += rethook.o rethook_trampoline.o > obj-$(CONFIG_KPROBES_ON_FTRACE) += ftrace.o > obj-$(CONFIG_UPROBES) += uprobes.o decode-insn.o simulate-insn.o > CFLAGS_REMOVE_simulate-insn.o = $(CC_FLAGS_FTRACE) > diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c > index e6e950b7c..f21592d20 100644 > --- a/arch/riscv/kernel/probes/kprobes.c > +++ b/arch/riscv/kernel/probes/kprobes.c > @@ -345,19 +345,6 @@ int __init arch_populate_kprobe_blacklist(void) > return ret; > } > > -void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs) > -{ > - return (void *)kretprobe_trampoline_handler(regs, NULL); > -} > - > -void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri, > - struct pt_regs *regs) > -{ > - ri->ret_addr = (kprobe_opcode_t *)regs->ra; > - ri->fp = NULL; > - regs->ra = (unsigned long) &__kretprobe_trampoline; > -} > - > int __kprobes arch_trampoline_kprobe(struct kprobe *p) > { > return 0; > diff --git a/arch/riscv/kernel/probes/rethook.c b/arch/riscv/kernel/probes/rethook.c > new file mode 100644 > index 000000000..cbd0da059 > --- /dev/null > +++ b/arch/riscv/kernel/probes/rethook.c > @@ -0,0 +1,27 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Generic return hook for riscv. > + */ > + > +#include > +#include > +#include "rethook.h" > + > +/* This is called from arch_rethook_trampoline() */ > +unsigned long __used arch_rethook_trampoline_callback(struct pt_regs *regs) > +{ > + return rethook_trampoline_handler(regs, regs->s0); > +} > +NOKPROBE_SYMBOL(arch_rethook_trampoline_callback); > + > + > +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount) > +{ > + rhn->ret_addr = regs->ra; > + rhn->frame = regs->s0; > + > + /* replace return addr with trampoline */ > + regs->ra = (unsigned long)arch_rethook_trampoline; > +} > +NOKPROBE_SYMBOL(arch_rethook_prepare); > + > diff --git a/arch/riscv/kernel/probes/rethook.h b/arch/riscv/kernel/probes/rethook.h > new file mode 100644 > index 000000000..cc573d701 > --- /dev/null > +++ b/arch/riscv/kernel/probes/rethook.h > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#ifndef __RISCV_RETHOOK_H > +#define __RISCV_RETHOOK_H > + > +unsigned long arch_rethook_trampoline_callback(struct pt_regs *regs); > +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount); > + > +#endif > diff --git a/arch/riscv/kernel/probes/kprobes_trampoline.S b/arch/riscv/kernel/probes/rethook_trampoline.S > similarity index 94% > rename from arch/riscv/kernel/probes/kprobes_trampoline.S > rename to arch/riscv/kernel/probes/rethook_trampoline.S > index 7bdb09ded..21bac92a1 100644 > --- a/arch/riscv/kernel/probes/kprobes_trampoline.S > +++ b/arch/riscv/kernel/probes/rethook_trampoline.S > @@ -75,13 +75,13 @@ > REG_L x31, PT_T6(sp) > .endm > > -ENTRY(__kretprobe_trampoline) > +ENTRY(arch_rethook_trampoline) > addi sp, sp, -(PT_SIZE_ON_STACK) > save_all_base_regs > > move a0, sp /* pt_regs */ > > - call trampoline_probe_handler > + call arch_rethook_trampoline_callback > > /* use the result as the return-address */ > move ra, a0 > @@ -90,4 +90,4 @@ ENTRY(__kretprobe_trampoline) > addi sp, sp, PT_SIZE_ON_STACK > > ret > -ENDPROC(__kretprobe_trampoline) > +ENDPROC(arch_rethook_trampoline) > -- > 2.27.0 > -- Masami Hiramatsu (Google) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv