From: Conor Dooley <conor@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: Daire McNamara <daire.mcnamara@microchip.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] mpfs: fix handling failed service requests
Date: Wed, 23 Nov 2022 17:56:50 +0000 [thread overview]
Message-ID: <20221123175652.327859-1-conor@kernel.org> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
As things stand, if a service request fails, we never know about it as
the status register is not read. This is quite obviously far from ideal,
as we would be reading garbage from the mailbox if a service was to
fail.
This pair of patches adds handling of the service status to both sides
of the mailbox implementation.
@Jassi, there should be no build, or really functional, dependency here
between patches. In the failing case, the buffer is allocated by the
service driver, so things will "work" just as badly as they did before
if only one of the patches is present. As a result, should be safe to do
the mailbox patch via your tree & the client via the soc tree.
Thanks,
Conor.
Changes since v2:
- Stop redefining the already existing #defines for status register.
Changes since v1:
- Send the patches I meant to send, with an extraneous ; removed.
Conor Dooley (2):
soc: microchip: mpfs: handle failed system service requests
mailbox: mpfs: read the system controller's status
drivers/mailbox/mailbox-mpfs.c | 31 +++++++++++++++++++--
drivers/soc/microchip/mpfs-sys-controller.c | 6 ++++
2 files changed, 34 insertions(+), 3 deletions(-)
--
2.38.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2022-11-23 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 17:56 Conor Dooley [this message]
2022-11-23 17:56 ` [PATCH v3 1/2] soc: microchip: mpfs: handle failed system service requests Conor Dooley
2022-12-09 19:14 ` Palmer Dabbelt
2022-11-23 17:56 ` [PATCH v3 2/2] mailbox: mpfs: read the system controller's status Conor Dooley
2022-12-09 19:14 ` Palmer Dabbelt
2022-12-26 22:46 ` (subset) [PATCH v3 0/2] mpfs: fix handling failed service requests Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123175652.327859-1-conor@kernel.org \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).