Re: [PATCH v3 4/7] dt-bindings: net: Add support StarFive dwmac

Krzysztof Kozlowski
2023-01-18T08:00:21Z

On 18/01/2023 02:45, yanhong wang wrote:
>
>
> On 2023/1/6 20:45, Krzysztof Kozlowski wrote:
>> On 06/01/2023 03:59, Yanhong Wang wrote:
>>> Add documentation to describe StarFive dwmac driver(GMAC).
>>>
>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>>> ---
>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
>>> .../bindings/net/starfive,jh7110-dwmac.yaml | 113 ++++++++++++++++++
>>> MAINTAINERS | 5 +
>>
>> Order the patches correctly. Why this binding patch is split from previous?
>>
>
> The previous binding patch was considered to be compatible with JH7100, but after discussion,
> it is not compatible with JH7100 for the time being, so the name of binding has been modified
> in this patch.

I am not asking about name, but why this was split from the patch using
the compatible in the first time. This does not make any sense. Please
squash.

Best regards,
Krzysztof