Re: [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names

Krzysztof Kozlowski
2023-01-17T08:43:47Z

On 17/01/2023 09:14, yanhong wang wrote:
>>> Thanks, refer to the definition of clocks. If it is defined as follows, is it OK?
>>>
>>> properties:
>>> resets:
>>> minItems: 1
>>> maxItems: 3
>>> additionalItems: true
>>
>> Drop
>>
>>> items:
>>> - description: MAC Reset signal.
>>
>> Drop both
>>
>>>
>>> reset-names:
>>> minItems: 1
>>> maxItems: 3
>>> additionalItems: true
>>
>> Drop
>>
>>> contains:
>>> enum:
>>> - stmmaceth
>>
>> Drop all
>>
>>>
>>>
>>> allOf:
>>> - if:
>>> properties:
>>> compatible:
>>> contains:
>>> const: starfive,jh7110-dwmac
>>> then:
>>> properties:
>>> resets:
>>> minItems: 2
>>> maxItems: 2
>>> reset-names:
>>> items:
>>> - const: stmmaceth
>>> - const: ahb
>>> required:
>>> - resets
>>> - reset-names
>>> else:
>>> properties:
>>> resets:
>>> maxItems: 1
>>> description:
>>> MAC Reset signal.
>>>
>>> reset-names:
>>> const: stmmaceth
>>>
>>> Do you have any other better suggestions?
>>
>> More or less like this but the allOf should not be in snps,dwmac schema
>> but in individual schemas. The snps,dwmac is growing unmaintainable...
>>
>
> Thanks, it is defined as follows, is it right?
>
> properties:
> resets:
> minItems: 1
> maxItems: 3
> additionalItems: true
>

Read my comments above. Drop.

Best regards,
Krzysztof