From: Andrew Jones <ajones@ventanamicro.com>
To: Leyfoon Tan <leyfoon.tan@starfivetech.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
'Anup Patel ' <apatel@ventanamicro.com>,
'Albert Ou ' <aou@eecs.berkeley.edu>,
'Paul Walmsley ' <paul.walmsley@sifive.com>,
JeeHeng Sia <jeeheng.sia@starfivetech.com>,
'Palmer Dabbelt ' <palmer@dabbelt.com>
Subject: Re: [RFC PATCH 1/1] riscv: sbi: Introduce system suspend support
Date: Tue, 10 Jan 2023 16:52:32 +0100 [thread overview]
Message-ID: <20230110155232.oildjprzhk65cnls@orel> (raw)
In-Reply-To: <739948a9f799485da88e0d7ed9f956e8@EXMBX161.cuchost.com>
On Tue, Jan 10, 2023 at 02:55:20PM +0000, Leyfoon Tan wrote:
>
> >
> > source "kernel/power/Kconfig"
> > diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h index
> > 4ca7fbacff42..9834ba4ce3e4 100644
> > --- a/arch/riscv/include/asm/sbi.h
> > +++ b/arch/riscv/include/asm/sbi.h
> > @@ -29,6 +29,7 @@ enum sbi_ext_id {
> > SBI_EXT_RFENCE = 0x52464E43,
> > SBI_EXT_HSM = 0x48534D,
> > SBI_EXT_SRST = 0x53525354,
> > + SBI_EXT_SUSP = 0x53555350,
> > SBI_EXT_PMU = 0x504D55,
> >
> > /* Experimentals extensions must lie within this range */ @@ -113,6
> > +114,14 @@ enum sbi_srst_reset_reason {
> > SBI_SRST_RESET_REASON_SYS_FAILURE,
> > };
> >
> > +enum sbi_ext_susp_fid {
> > + SBI_EXT_SUSP_SUSPEND = 0,
>
> Macro name with "*_SYSTEM_SUSPEND" is better? Avoid confusing with CPU suspend.
The _SUSP_ part should cover that, but I'm OK with adding SYSTEM as well.
>
> > +};
> > +
> > +enum sbi_ext_susp_sleep_type {
> > + SBI_SUSP_SLEEP_TYPE_SUSPEND = 0,
> This should be SBI_SUSP_SLEEP_TYPE_SUSPEND_TO_RAM?
Yes, that would be better. I'll change that for the next version.
Thanks,
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-10 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:32 [RFC PATCH 0/1] riscv: Introduce system suspend support Andrew Jones
2023-01-06 11:32 ` [RFC PATCH 1/1] riscv: sbi: " Andrew Jones
2023-01-10 14:55 ` Leyfoon Tan
2023-01-10 15:52 ` Andrew Jones [this message]
2023-01-10 22:23 ` Conor Dooley
2023-01-11 8:52 ` Andrew Jones
2023-01-11 9:06 ` Conor Dooley
2023-01-11 9:16 ` Andrew Jones
2023-01-17 22:34 ` [RFC PATCH 0/1] riscv: " Conor Dooley
2023-01-18 11:55 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110155232.oildjprzhk65cnls@orel \
--to=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=apatel@ventanamicro.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox