public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Nylon Chen <nylon.chen@sifive.com>
To: paul.walmsley@sifive.com, palmer@dabbelt.com,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com,
	vincent.chen@sifive.com, Nylon Chen <nylon.chen@sifive.com>
Subject: [PATCH 2/2] pwm: sifive: change the PWM controlled LED algorithm
Date: Fri, 13 Jan 2023 16:31:15 +0800	[thread overview]
Message-ID: <20230113083115.2590-3-nylon.chen@sifive.com> (raw)
In-Reply-To: <20230113083115.2590-1-nylon.chen@sifive.com>

The `frac` variable represents the pulse inactive time, and the result of
this algorithm is the pulse active time. Therefore, we must reverse the
result.

Signed-off-by: Nylon Chen <nylon.chen@sifive.com>
Reviewed-by: Vincent Chen <vincent.chen@sifive.com>
---
 drivers/pwm/pwm-sifive.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
index 62b6acc6373d..a5eda165d071 100644
--- a/drivers/pwm/pwm-sifive.c
+++ b/drivers/pwm/pwm-sifive.c
@@ -158,6 +158,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 	frac = DIV64_U64_ROUND_CLOSEST(num, state->period);
 	/* The hardware cannot generate a 100% duty cycle */
 	frac = min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1);
+	frac = (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac;
 
 	mutex_lock(&ddata->lock);
 	if (state->period != ddata->approx_period) {
-- 
2.36.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-01-13  8:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  8:31 [PATCH 0/2] Change PWM-controlled LED pin active mode and algorithm Nylon Chen
2023-01-13  8:31 ` [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties Nylon Chen
2023-01-17 13:57   ` Conor Dooley
2023-01-13  8:31 ` Nylon Chen [this message]
2023-01-13 18:32 ` [PATCH 0/2] Change PWM-controlled LED pin active mode and algorithm Conor Dooley
2023-01-13 19:24   ` Jessica Clarke
2023-01-14 14:00     ` Conor Dooley
2023-01-18  2:32       ` Nylon Chen
2023-01-18  8:13         ` Conor Dooley
2023-01-17  9:32     ` Nylon Chen
2023-01-17 15:08       ` Ron Economos
2023-01-18  1:46         ` Ron Economos
2023-01-18  3:40           ` Ron Economos
2023-01-18  2:30     ` Nylon Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113083115.2590-3-nylon.chen@sifive.com \
    --to=nylon.chen@sifive.com \
    --cc=greentime.hu@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=nylon7717@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vincent.chen@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox