From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8EADC636CC for ; Sat, 4 Feb 2023 20:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UewyCPaqQbmkJuHu3bewqYIAUkUOniK1FJi2fSUk9NA=; b=KTbhIWVYMYGbLn 36t4AycvFArH00xx4UY5gKBrjoTXsKfF6wlzHaTHZRAnYXWTelI93MXArTy6sAs3rOuhisMAx/zHY /HNAW5B2Ws+z6LEEO/GecVjv9oo3TcYc2K634snC4vExhj+f4thuqZ6ygZYuyT+87AGbN8RjRNteW JKMOf2UYI9nVmXyBPKv/HaixbyKpSe13JoeaAeHIvUpSKkRCiROjdzqIblN5j/d2Y7lBiWTew5+Ha N6hpOR8aqoj5Zp5WFX1X2lpetLAbyvjT5CcpqweOxiWIR43o3Kyp6iYPCv0/zCqcqh2esDPLX/m6d saw2GZJ8sMNrDzrN6YqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOPOR-005YX0-UL; Sat, 04 Feb 2023 20:44:15 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOPOO-005YVy-6M for linux-riscv@lists.infradead.org; Sat, 04 Feb 2023 20:44:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675543452; x=1707079452; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IR+38awXRWxdcpHN+7aQRcTcrCcg3s4/G2wGNCzeLis=; b=VxEfrdg0GBF34b7YTYveM3ar12fBpZ8+9pFiGwVnofE6Dyc3n4zWSNsx pquw+sEpn3FXomDWGEJ5C7IpcBMK448oYxebRjgZODrWZ442ItkN0aEOH gPx2z73sU6s+nmZWUvRJTxA7EXwAupH7bqh9zT116O+e97VsZ92kZIW4K 8K0JrIWfYdXNiflJMZsvoBI0PZVSK8VpmHkb4Tmpbz7k1jsCAvA6UO0ul QWFEDXS/x4hafoT+wK0QAftt5maB19cNynw0damjsAGV470dSwhka3cEz o+9MAlzUkU17LMvTBNK74U7XkQnTjBlmTHwYsDw0z+K1Tayli7lNlnAFO g==; X-IronPort-AV: E=McAfee;i="6500,9779,10611"; a="327617105" X-IronPort-AV: E=Sophos;i="5.97,272,1669104000"; d="scan'208";a="327617105" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2023 12:43:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10611"; a="729621552" X-IronPort-AV: E=Sophos;i="5.97,272,1669104000"; d="scan'208";a="729621552" Received: from lkp-server01.sh.intel.com (HELO 4455601a8d94) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 04 Feb 2023 12:43:56 -0800 Received: from kbuild by 4455601a8d94 with local (Exim 4.96) (envelope-from ) id 1pOPO7-0001WS-1q; Sat, 04 Feb 2023 20:43:55 +0000 Date: Sun, 5 Feb 2023 04:42:58 +0800 From: kernel test robot To: Sia Jee Heng , paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: oe-kbuild-all@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, jeeheng.sia@starfivetech.com, leyfoon.tan@starfivetech.com, mason.huo@starfivetech.com Subject: Re: [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk Message-ID: <202302050450.VM99IQpW-lkp@intel.com> References: <20230127091051.1465278-5-jeeheng.sia@starfivetech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127091051.1465278-5-jeeheng.sia@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230204_124412_297045_3CCBBADD X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Sia, Thank you for the patch! Yet something to improve: [auto build test ERROR on 7c46948a6e9cf47ed03b0d489fde894ad46f1437] url: https://github.com/intel-lab-lkp/linux/commits/Sia-Jee-Heng/RISC-V-Change-suspend_save_csrs-and-suspend_restore_csrs-to-public-function/20230128-114249 base: 7c46948a6e9cf47ed03b0d489fde894ad46f1437 patch link: https://lore.kernel.org/r/20230127091051.1465278-5-jeeheng.sia%40starfivetech.com patch subject: [PATCH v3 4/4] RISC-V: Add arch functions to support hibernation/suspend-to-disk config: riscv-randconfig-r001-20230205 (https://download.01.org/0day-ci/archive/20230205/202302050450.VM99IQpW-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/642c1b119b3d33fe0ee22ff6823085cb847cfe79 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sia-Jee-Heng/RISC-V-Change-suspend_save_csrs-and-suspend_restore_csrs-to-public-function/20230128-114249 git checkout 642c1b119b3d33fe0ee22ff6823085cb847cfe79 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): riscv64-linux-ld: arch/riscv/kernel/hibernate.o: in function `arch_hibernation_header_restore': >> arch/riscv/kernel/hibernate.c:133: undefined reference to `__cpu_suspend_enter' >> riscv64-linux-ld: arch/riscv/kernel/hibernate.c:137: undefined reference to `suspend_save_csrs' >> riscv64-linux-ld: arch/riscv/kernel/hibernate.c:137: undefined reference to `suspend_restore_csrs' pahole: .tmp_vmlinux.btf: No such file or directory .btf.vmlinux.bin.o: file not recognized: file format not recognized vim +133 arch/riscv/kernel/hibernate.c 106 107 /* 108 * Retrieve the helper parameters from the hibernation image header 109 */ 110 int arch_hibernation_header_restore(void *addr) 111 { 112 struct arch_hibernate_hdr_invariants invariants; 113 struct arch_hibernate_hdr *hdr = addr; 114 int ret = 0; 115 116 arch_hdr_invariants(&invariants); 117 118 if (memcmp(&hdr->invariants, &invariants, sizeof(invariants))) { 119 pr_crit("Hibernate image not generated by this kernel!\n"); 120 return -EINVAL; 121 } 122 123 sleep_cpu = riscv_hartid_to_cpuid(hdr->hartid); 124 if (sleep_cpu < 0) { 125 pr_crit("Hibernated on a CPU not known to this kernel!\n"); 126 sleep_cpu = -EINVAL; 127 return -EINVAL; 128 } 129 130 #ifdef CONFIG_SMP 131 ret = bringup_hibernate_cpu(sleep_cpu); 132 if (ret) { > 133 sleep_cpu = -EINVAL; 134 return ret; 135 } 136 #endif > 137 resume_hdr = *hdr; 138 139 return ret; 140 } 141 EXPORT_SYMBOL(arch_hibernation_header_restore); 142 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv