From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ED3EC636D3 for ; Tue, 7 Feb 2023 20:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YN7kGP3jQcm46xJoV3/v5tqWNRDTbpmtzuL8JC69GKU=; b=laKktX9eMluVuW 7eMKYILK5S6LvdgFj3w+zomzMXDpKl4ihJLaoSSBXkBZaknNyLKN03yo6g2oBU2ucpdYBD8CvbTaA IKDyOOdEgeEqQa4kAfLKso6tEBJGKhHLIH5CGitBwu5PRRmewFqfX2+OhUPA80Z+Rq3NlULzqocG4 CNqdFkJsqEpVmwx8b3sfXfGcP6qRG3XOA1b4tv1VAFH5cjxoieRvbwd0m0OElUs6tUvUOLzAeBIG1 gs/L7IWICPNl/VmY9n01Tm6su6bDvUI5PS7I8Yd4UnEenaQS0kbFgmF449SUOb2OAF9aMQKo0y0M3 Hfp9RInBLPx3XRx6Tnew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPV2T-00DOc2-EN; Tue, 07 Feb 2023 20:58:05 +0000 Received: from mail-oa1-f54.google.com ([209.85.160.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPV2Q-00DOaR-BA for linux-riscv@lists.infradead.org; Tue, 07 Feb 2023 20:58:03 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1685cf2003aso20596082fac.12 for ; Tue, 07 Feb 2023 12:58:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yqtKI6VvbLeNL2RUrUWXNfeUaIXVwWm1vJplGrZvFTs=; b=3xVyvHlGXmlGXwAyEhvN9+ZhBft4nvdQk2edeO6OmdgDn4Wmj4NGAgzNVvQEYyHidl PxyQeLc164WkZFHhyZkjhuFvdYId+89Pja9h/FK3I4A0dr/CyqI7hzSc/SYBiIzYSGsj TrS4reSzhO8czV+bhqsEFSV7i5cjbU8J9xVOhGH9y+A9qnsOPoH8XNAi6V3OnbgTtGbE YfFcuvkWpaAq2Z713vHW0VBgkVd8vGAUly5Dy5M5kgrGz1BO2Y8cU/8osVs3p8TOEQFj BLECS9q1pF0GYxfPntcZJjDDoDUik/H8jf7PBaLKuMF5Iwfo9XiR1veVJ7eus1GV4mao iFNA== X-Gm-Message-State: AO0yUKUdaUrP1Bg63AG7gyA1HzXoD8u4jJuBbwlg3Ul1tAb0B7mR9UK2 PvItIX7XMzlpbLRIPQYuKQ== X-Google-Smtp-Source: AK7set9bFssBm+5bRaiQQaqfvXv/9qHnz1QnYd/r18TnCsF10XdNoZ3shz76XhSe7GxcLpeT/Kg5Gw== X-Received: by 2002:a05:6870:ec91:b0:16a:2a6d:9e40 with SMTP id eo17-20020a056870ec9100b0016a2a6d9e40mr2489358oab.29.1675803481127; Tue, 07 Feb 2023 12:58:01 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id b9-20020a9d6b89000000b0068bcef4f543sm7025713otq.21.2023.02.07.12.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:00 -0800 (PST) Received: (nullmailer pid 4142751 invoked by uid 1000); Tue, 07 Feb 2023 20:58:00 -0000 Date: Tue, 7 Feb 2023 14:58:00 -0600 From: Rob Herring To: Walker Chen Cc: linux-riscv@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, Eugeniy Paltsev , Vinod Koul , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Emil Renner Berthing , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] dt-bindings: dma: snps,dw-axi-dmac: Update resets and add snps,num-hs-if Message-ID: <20230207205800.GA4140140-robh@kernel.org> References: <20230206113811.23133-1-walker.chen@starfivetech.com> <20230206113811.23133-2-walker.chen@starfivetech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206113811.23133-2-walker.chen@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_125802_407999_7D57D2DD X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 07:38:09PM +0800, Walker Chen wrote: > Add two reset items and properties 'snps,num-hs-if'. > The DMA controller needs to be reset before being used in JH7110 SoC. > Another difference from the original version is that the hardware > handshake number of DMA can be up to 56 while the number in original > version is less than 16, and different registers are selected according > to this. > > Signed-off-by: Walker Chen > --- > .../bindings/dma/snps,dw-axi-dmac.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > index 67aa7bb6d36a..1a8d8c20e254 100644 > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > @@ -9,6 +9,7 @@ title: Synopsys DesignWare AXI DMA Controller > maintainers: > - Eugeniy Paltsev > - Jee Heng Sia > + - Walker Chen > > description: > Synopsys DesignWare AXI DMA Controller DT Binding > @@ -21,6 +22,7 @@ properties: > enum: > - snps,axi-dma-1.01a > - intel,kmb-axi-dma > + - starfive,axi-dma This should be SoC specific. > > reg: > minItems: 1 > @@ -59,7 +61,12 @@ properties: > maximum: 8 > > resets: > - maxItems: 1 > + maxItems: 2 > + > + reset-names: > + items: > + - const: axi-rst > + - const: ahb-rst '-rst' is redundant. > > snps,dma-masters: > description: | > @@ -74,6 +81,14 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 1, 2, 3, 4, 5, 6] > > + snps,num-hs-if: > + description: | > + The number of hardware handshake. If it is more than 16, > + CHx_CFG2 is used to configure the DMA transfer instead of CHx_CFG. Can't you infer this from the compatible string? > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 256 > + > snps,priority: > description: | > Channel priority specifier associated with the DMA channels. > -- > 2.17.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv