Re: [PATCH v2 1/3] dt-bindings: dma: snps,dw-axi-dmac: Add reset items

Walker Chen
2023-02-24T10:15:35Z

On 2023/2/22 17:17, Krzysztof Kozlowski wrote:
> On 21/02/2023 15:04, Walker Chen wrote:
>> This DMA controller needs to be reset before being used on JH7110 SoC,
>> so add reset items to support this chip.
>
> There is reset already. The DMA controller is reset already. Your commit
> msg and commit subject do not match commit at all.

OK, the commit message will be changed to match the actual modification.

>
>>
>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
>> ---
>> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index ad107a4d3b33..c2247c65a22f 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -20,6 +20,7 @@ properties:
>> enum:
>> - snps,axi-dma-1.01a
>> - intel,kmb-axi-dma
>> + - starfive,jh7110-axi-dma
>>
>> reg:
>> minItems: 1
>> @@ -58,7 +59,12 @@ properties:
>> maximum: 8
>>
>> resets:
>> - maxItems: 1
>> + maxItems: 2
>
> This breaks ABI and all other users. Test your changes before sending.

I think 'minItems' should be added here. So like this:
resets:
minItems: 1
maxItems: 2

Other platform/users will not be affected by this.

Thanks.

Best regards,
Walker