Re: [PATCH -next v14 09/19] riscv: Add task switch support for vector

Björn Töpel
2023-03-01T16:57:40Z

Conor Dooley <conor@kernel.org> writes:

> Hey Andy,
>
> On Fri, Feb 24, 2023 at 05:01:08PM +0000, Andy Chiu wrote:
>> From: Greentime Hu <greentime.hu@sifive.com>
>>
>> This patch adds task switch support for vector. It also supports all
>> lengths of vlen.
>>
>> [guoren@linux.alibaba.com: First available porting to support vector
>> context switching]
>> [nick.knight@sifive.com: Rewrite vector.S to support dynamic vlen, xlen and
>> code refine]
>> [vincent.chen@sifive.com: Fix the might_sleep issue in riscv_v_vstate_save,
>> riscv_v_vstate_restore]
>> [andrew@sifive.com: Optimize task switch codes of vector]
>> [ruinland.tsai@sifive.com: Fix the arch_release_task_struct free wrong
>> datap issue]
>> [vineetg: Fixed lkp warning with W=1 build]
>> [andy.chiu: Use inline asm for task switches]
>
> Can we *please* get rid of these silly changelogs in the commit messages?
> Either someone did something worthy of being a co-developer on the
> patch, or this belongs under the --- line.
> It's a bit ridiculous I think to have a 15 word commit message for the
> patch, but have like 8 different bits of per-version changelogs...

Yes, please! And not only for this patch, but for the series in
general. The series needs a respin for various reasons, so now would be
a good opportunity to clean up the changelog.

Simply move it to the cover letter, or below --- as Conor suggests.