Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

Dmitry Baryshkov
2023-03-03T23:41:29Z

On 03/03/2023 23:42, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-phy@lists.infradead.org
> Cc: linux-gpio@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-riscv@lists.infradead.org
> Cc: linux-spi@vger.kernel.org
> ---
> Documentation/devicetree/bindings/.yamllint | 2 +-
> .../bindings/clock/qcom,a53pll.yaml | 4 ++--
> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 4 ++--
> .../bindings/display/msm/qcom,mdp5.yaml | 2 +-
> .../interrupt-controller/arm,gic.yaml | 4 ++--
> .../loongson,pch-msi.yaml | 2 +-
> .../bindings/media/renesas,vin.yaml | 4 ++--
> .../devicetree/bindings/media/ti,cal.yaml | 4 ++--
> .../bindings/net/brcm,bcmgenet.yaml | 2 --
> .../bindings/net/cortina,gemini-ethernet.yaml | 6 ++---
> .../devicetree/bindings/net/mdio-gpio.yaml | 4 ++--
> .../phy/marvell,armada-cp110-utmi-phy.yaml | 2 +-
> .../bindings/phy/phy-stm32-usbphyc.yaml | 2 +-
> .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 2 +-
> .../bindings/pinctrl/pinctrl-mt8192.yaml | 2 +-
> .../regulator/nxp,pca9450-regulator.yaml | 8 +++----
> .../regulator/rohm,bd71828-regulator.yaml | 20 ++++++++--------
> .../regulator/rohm,bd71837-regulator.yaml | 6 ++---
> .../regulator/rohm,bd71847-regulator.yaml | 6 ++---
> .../bindings/soc/renesas/renesas.yaml | 2 +-
> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 2 +-
> .../bindings/sound/amlogic,axg-tdm-iface.yaml | 2 +-
> .../bindings/sound/qcom,lpass-rx-macro.yaml | 4 ++--
> .../bindings/sound/qcom,lpass-tx-macro.yaml | 4 ++--
> .../bindings/sound/qcom,lpass-va-macro.yaml | 4 ++--
> .../sound/qcom,q6dsp-lpass-ports.yaml | 2 +-
> .../bindings/sound/simple-card.yaml | 24 +++++++++----------
> .../bindings/spi/microchip,mpfs-spi.yaml | 2 +-
> 28 files changed, 65 insertions(+), 67 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # drm/msm
(and other Qualcom-specific schemas)

--
With best wishes
Dmitry