Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

Conor Dooley
2023-03-03T23:01:34Z

[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]

On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

> Cc: Conor Dooley <conor.dooley@microchip.com>

> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi

I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]