public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core
@ 2023-03-24  6:46 Hal Feng
  2023-03-24 19:05 ` Conor Dooley
  0 siblings, 1 reply; 2+ messages in thread
From: Hal Feng @ 2023-03-24  6:46 UTC (permalink / raw)
  To: devicetree, linux-riscv
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Palmer Dabbelt,
	Paul Walmsley, Albert Ou, Emil Renner Berthing, Hal Feng,
	linux-kernel

The S7 core has no L1 data cache and MMU, so delete some
related properties.

Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---

Hi, Conor,

This is a correction for the S7 entry.
This patch depends on patch [1].

[1] https://lore.kernel.org/all/20230320103750.60295-20-hal.feng@starfivetech.com/

---
 arch/riscv/boot/dts/starfive/jh7110.dtsi | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
index d484ecdf93f7..4c5fdb905da8 100644
--- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
@@ -20,21 +20,12 @@ cpus {
 		S7_0: cpu@0 {
 			compatible = "sifive,s7", "riscv";
 			reg = <0>;
-			d-cache-block-size = <64>;
-			d-cache-sets = <64>;
-			d-cache-size = <8192>;
-			d-tlb-sets = <1>;
-			d-tlb-size = <40>;
 			device_type = "cpu";
 			i-cache-block-size = <64>;
 			i-cache-sets = <64>;
 			i-cache-size = <16384>;
-			i-tlb-sets = <1>;
-			i-tlb-size = <40>;
-			mmu-type = "riscv,sv39";
 			next-level-cache = <&ccache>;
 			riscv,isa = "rv64imac_zba_zbb";
-			tlb-split;
 			status = "disabled";
 
 			cpu0_intc: interrupt-controller {
-- 
2.38.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core
  2023-03-24  6:46 [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core Hal Feng
@ 2023-03-24 19:05 ` Conor Dooley
  0 siblings, 0 replies; 2+ messages in thread
From: Conor Dooley @ 2023-03-24 19:05 UTC (permalink / raw)
  To: Hal Feng
  Cc: devicetree, linux-riscv, Rob Herring, Krzysztof Kozlowski,
	Palmer Dabbelt, Paul Walmsley, Albert Ou, Emil Renner Berthing,
	linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1672 bytes --]

On Fri, Mar 24, 2023 at 02:46:51PM +0800, Hal Feng wrote:
> The S7 core has no L1 data cache and MMU, so delete some
> related properties.
> 
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> 
> Hi, Conor,
> 
> This is a correction for the S7 entry.

Again going off the latest version of the u74-mc core complex, this
looks to be correct, thanks.
I need to go read the Emil email from earier today, but I've
provisionally gone and put this on the riscv-jh7100_initial_dts branch
with a Fixes: tag.

Thanks,
Conor.

> This patch depends on patch [1].
> 
> [1] https://lore.kernel.org/all/20230320103750.60295-20-hal.feng@starfivetech.com/
> 
> ---
>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index d484ecdf93f7..4c5fdb905da8 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -20,21 +20,12 @@ cpus {
>  		S7_0: cpu@0 {
>  			compatible = "sifive,s7", "riscv";
>  			reg = <0>;
> -			d-cache-block-size = <64>;
> -			d-cache-sets = <64>;
> -			d-cache-size = <8192>;
> -			d-tlb-sets = <1>;
> -			d-tlb-size = <40>;
>  			device_type = "cpu";
>  			i-cache-block-size = <64>;
>  			i-cache-sets = <64>;
>  			i-cache-size = <16384>;
> -			i-tlb-sets = <1>;
> -			i-tlb-size = <40>;
> -			mmu-type = "riscv,sv39";
>  			next-level-cache = <&ccache>;
>  			riscv,isa = "rv64imac_zba_zbb";
> -			tlb-split;
>  			status = "disabled";
>  
>  			cpu0_intc: interrupt-controller {
> -- 
> 2.38.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-24 19:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-24  6:46 [PATCH v1] riscv: dts: starfive: jh7110: Correct the properties of S7 core Hal Feng
2023-03-24 19:05 ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox