Re: [PATCH v5 08/10] reset: starfive: jh7110: Add StarFive STG/ISP/VOUT resets support

Xingyu Wu
2023-05-18T01:25:52Z

On 2023/5/17 21:19, Andreas Schwab wrote:
> On Apr 24 2023, Xingyu Wu wrote:
>
>> @@ -58,6 +76,18 @@ static const struct auxiliary_device_id jh7110_reset_ids[] = {
>> .name = "clk_starfive_jh7110_sys.rst-aon",
>> .driver_data = (kernel_ulong_t)&jh7110_aon_info,
>> },
>> + {
>> + .name = "clk_starfive_jh7110_sys.rst-stg",
>> + .driver_data = (kernel_ulong_t)&jh7110_stg_info,
>> + },
>> + {
>> + .name = "clk_starfive_jh7110_sys.rst-isp",
>> + .driver_data = (kernel_ulong_t)&jh7110_isp_info,
>> + },
>> + {
>> + .name = "clk_starfive_jh7110_sys.rst-vout",
>
> "clk_starfive_jh7110_sys.rst-vout" is exactly AUXILIARY_NAME_SIZE long,
> thus lacks a null termination.
>

Yeah, it should be modified to "clk_starfive_jh7110_sys.rst-vo" in this and
use "rst-vo" instead of "rst-vout" in the probe of vout clock driver.
Then it will work.

Best regards,
Xingyu Wu