From: Conor Dooley <conor@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Pranavi Somisetty <pranavi.somisetty@amd.com>,
nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
linux@armlinux.org.uk, palmer@dabbelt.com, git@amd.com,
michal.simek@amd.com, harini.katakam@amd.com,
radhey.shyam.pandey@amd.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property
Date: Thu, 11 May 2023 23:29:20 +0100 [thread overview]
Message-ID: <20230511-unhidden-mummify-800fe847e25d@spud> (raw)
In-Reply-To: <20230511-canned-gray-005130594368@wendy>
[-- Attachment #1.1: Type: text/plain, Size: 1054 bytes --]
On Thu, May 11, 2023 at 08:25:15AM +0100, Conor Dooley wrote:
> On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote:
> > watermark value is the minimum amount of packet data
> > required to activate the forwarding process. The watermark
> > implementation and maximum size is dependent on the device
> > where Cadence MACB/GEM is used.
> >
> > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com>
>
> Please send dt-binding patches to the dt-binding maintainers and list.
> get_maintainer.pl should have told you to do so & without having done
> so, the bindings will not get tested :/
The automation we run for the linux-riscv did actually run against
this though, and even dtbs_check complains about this binding:
Documentation/devicetree/bindings/net/cdns,macb.yaml: properties:rx-watermark:maxItems: False schema does not allow 1
hint: Scalar properties should not have array keywords
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
Please test your bindings :/
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-05-11 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 7:12 [PATCH net-next v2 0/2] Add support for partial store and forward Pranavi Somisetty
2023-05-11 7:12 ` [PATCH net-next v2 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property Pranavi Somisetty
2023-05-11 7:25 ` Conor Dooley
2023-05-11 22:29 ` Conor Dooley [this message]
2023-05-11 14:03 ` Krzysztof Kozlowski
2023-05-11 15:41 ` Andrew Lunn
2023-05-11 7:12 ` [PATCH net-next v2 2/2] net: macb: Add support for partial store and forward Pranavi Somisetty
2023-05-11 7:28 ` Conor Dooley
2023-05-11 13:08 ` Simon Horman
2023-05-11 15:49 ` Andrew Lunn
2023-05-12 7:57 ` Claudiu.Beznea
2023-05-12 11:53 ` Somisetty, Pranavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511-unhidden-mummify-800fe847e25d@spud \
--to=conor@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=harini.katakam@amd.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pranavi.somisetty@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox