Re: [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI

Mark Brown
2023-05-26T15:36:30Z

[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]

On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote:

> if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) {
> + qspi_ahb = devm_clk_get(dev, "qspi-ahb");
> + if (IS_ERR(qspi_ahb)) {
> + dev_err(dev, "Cannot claim QSPI_AHB clock.\n");
> + ret = PTR_ERR(qspi_ahb);
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(qspi_ahb);
> + if (ret) {
> + dev_err(dev, "Cannot enable QSPI AHB clock.\n");
> + goto probe_clk_failed;
> + }

Nothing ever disables or unprepares this clock as far as I can tell?
Perhaps also consider using the clk_bulk_ APIs.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]