Re: [PATCH v1 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for StarFive JH7110 SoC

Mark Brown
2023-05-30T10:03:05Z

[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

On Mon, May 29, 2023 at 02:44:13PM +0800, William Qiu wrote:
> On 2023/5/26 23:33, Mark Brown wrote:
> > On Fri, May 26, 2023 at 02:25:27PM +0800, William Qiu wrote:

> >> + clock-names:
> >> + items:
> >> + - const: qspi-ref
> >> + - const: qspi-ahb
> >> + - const: qspi-apb

> I'm going to change the names of these three clocks to hclk, pclk,
> and ref_clk, as defined in the data book. What do you think?

That looks fine. ref, ahb and apb would also be fine, it's just the
qspi- prefix that I was querying.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]