Re: [PATCH v1 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI

William Qiu
2023-05-30T02:06:17Z

On 2023/5/29 14:44, William Qiu wrote:
>
>
> On 2023/5/26 23:36, Mark Brown wrote:
>> On Fri, May 26, 2023 at 02:25:28PM +0800, William Qiu wrote:
>>
>>> if (of_device_is_compatible(pdev->dev.of_node, "starfive,jh7110-qspi")) {
>>> + qspi_ahb = devm_clk_get(dev, "qspi-ahb");
>>> + if (IS_ERR(qspi_ahb)) {
>>> + dev_err(dev, "Cannot claim QSPI_AHB clock.\n");
>>> + ret = PTR_ERR(qspi_ahb);
>>> + return ret;
>>> + }
>>> +
>>> + ret = clk_prepare_enable(qspi_ahb);
>>> + if (ret) {
>>> + dev_err(dev, "Cannot enable QSPI AHB clock.\n");
>>> + goto probe_clk_failed;
>>> + }
>>
>> Nothing ever disables or unprepares this clock as far as I can tell?
>> Perhaps also consider using the clk_bulk_ APIs.
>
> I will add in next version.
>
> Thanks for taking time to review this patch series and give useful
> suggestions.
>
> Best regards,
> William

Hi Mark,

Now I want to replace the original devm_clk_get API in the
driver with devm_clk_bulk_get_all API, which can achieve compatibility,
but it seems that it is not good for other ip with only one clock, so I
want to ask about that can I replace it? Or define that inside jh7110?

Best regards,
William